File create.format blueprint option also converts mp4 to broken webp

[distantnative]

create:
  width: 1920
  height: 1920
  format: webp

If the file blueprint also accept non-image files, those will be skipped and their format/extension left untouched.

This should leave mp4 files unchanged, but it doesn't.

Original report: https://forum.getkirby.com/t/convert-image-formats-on-upload-file-blueprint-option-does-not-ignore-video-files-produces-broken-files-as-a-result/32600

[afbora]

I prefer moving changeExtension() calling process (after manipulate process) into ::manipulate() method. I think changeExtension process is part of manipulate action. What do you think?

kirby/src/Cms/FileActions.php

Lines 287 to 289 in f724075

	// resize the file on upload if configured
	$file = $file->manipulate($create);
	$file = $file->changeExtension($file, $create['format'] ?? null);

[distantnative]

Ahhh, I love how good you are at finding the sources of such issues. Yes, I think that's the problem that the extension gets changed even if manipulate exists without doing anything.

And your suggestion makes sense to me.

[francoislacruche]

Hi, I'm the OP of the issue on the forums. That means I should just wait for the next Kirby release, correct ? If yes, do you have a vague idea of how often fixes such as this one get implemented (or know somewhere I can learn more about your development process/roadmap) ?

Sorry if dumb questions, I'm curious but know little about such development environments.

[distantnative]

@francoislacruche Im pretty sure this will be part of the next release (4.5) as we already know the origin of the bug and that the fix will relatively easy.

On other issues it can take sometimes months or years if they are hard to replicate or their solutions first requires a lot of dependencies.

But here we'll have one soon I'm confident.