Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move changeExtension logic into manipulate method #6718

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Oct 3, 2024

Changelog

Fixes

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Oct 3, 2024
@afbora afbora added this to the 4.5.0 milestone Oct 3, 2024
@afbora afbora requested a review from a team October 3, 2024 09:29
@afbora afbora self-assigned this Oct 3, 2024
@afbora afbora linked an issue Oct 3, 2024 that may be closed by this pull request
src/Cms/FileActions.php Fixed Show fixed Hide fixed
@afbora afbora force-pushed the fix/6715-file-manipulate branch from 0b18cea to 90674e8 Compare October 3, 2024 09:35
@distantnative
Copy link
Member

@afbora Should we maybe also have a unit tests for the regular methods? E.g. testCreateWithManipulateForNonImage?

@distantnative
Copy link
Member

@afbora I think we misunderstood each other. My comment was not about the naming of "non image". My suggestion was to not just test the manipulate method in isolation, but actually tests methods like e.g. create with blueprint create option and a non image to ensure that they now really remain untouched.

@distantnative distantnative merged commit 0bc10cd into develop-minor Oct 3, 2024
12 checks passed
@distantnative distantnative deleted the fix/6715-file-manipulate branch October 3, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File create.format blueprint option also converts mp4 to broken webp
2 participants