Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages dropdown with changes/lock indicator #6793

Merged
merged 11 commits into from
Nov 14, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 13, 2024

Description

Summary of changes

  • Languages dropdown indicates default language
  • Languages dropdown indicates when has changes/locked
  • k-dropdown-content exposes items as scoped default slot
  • k-dropdown-content has new item scoped slot

@distantnative distantnative self-assigned this Nov 13, 2024
@distantnative distantnative force-pushed the v5/changes/languages-dropdown branch 2 times, most recently from 2995a56 to 926ee5d Compare November 14, 2024 06:46
@distantnative distantnative marked this pull request as ready for review November 14, 2024 06:47
@afbora
Copy link
Member

afbora commented Nov 14, 2024

I've found a lot of issues:

  • Wrong dot indicator
  • Wrong text indicator
  • Cannot discard some changes

I can reproduce with starterkit notes pages but not with default pages. Just edit some blocks and switch the languages. You'll see the all issues.

@distantnative
Copy link
Member Author

@afbora Could you please be more specific which steps lead to which problem? And also, is that an issue of this PR or on v5/changes/develop already?

@afbora
Copy link
Member

afbora commented Nov 14, 2024

@distantnative Yes wrong dot indicator and discarding changes issues still valid for v5/changes/develop branch.

Wrong dot & text indicator

  • Edit default language blocks without save
  • Switch to the secondary language and edit some blocks without save
  • Try to discard for secondary language
  • You'll see text and dot indicator is wrong

Another steps:

  • Switch to secondary language
  • Edit some blocks and discard it
  • Still showing indicator for secondary language

Discarding changes

  • Edit default language blocks without save
  • Switch to secondary language than go back to default language again without any edit
  • You'll see default language changes are gone.

Cannot discard some changes

It happened once or twice but I couldn't find the exact steps right now. If it happens again, I'll write it.

@bastianallgeier
Copy link
Member

So this seems to be a particular issue of the blocks field? Have you experienced the same with other fields?

@bastianallgeier
Copy link
Member

@distantnative I wouldn't add the old lab example to be honest.

@afbora
Copy link
Member

afbora commented Nov 14, 2024

@bastianallgeier I think you're right. Seems some locking process broken with blocks field.

@afbora
Copy link
Member

afbora commented Nov 14, 2024

I've done few more tests. I guess it's related with writer field not blocks field. Blocks field also have writer field.

@bastianallgeier
Copy link
Member

@afbora that makes sense. We had so many issues with the writer before. If I remember correctly, it's the way that the input event is triggered in the writer field. It doesn't only happen when you type something, it also happens when the value is updated via JS from the backend. That basically creates a wrong additional event.

@distantnative distantnative mentioned this pull request Nov 14, 2024
5 tasks
@distantnative distantnative merged commit 8f1db29 into v5/changes/develop Nov 14, 2024
15 checks passed
@distantnative distantnative deleted the v5/changes/languages-dropdown branch November 14, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants