-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Languages dropdown with changes/lock indicator #6793
Languages dropdown with changes/lock indicator #6793
Conversation
2995a56
to
926ee5d
Compare
I've found a lot of issues:
I can reproduce with starterkit notes pages but not with default pages. Just edit some blocks and switch the languages. You'll see the all issues. |
@afbora Could you please be more specific which steps lead to which problem? And also, is that an issue of this PR or on |
@distantnative Yes wrong dot indicator and discarding changes issues still valid for Wrong dot & text indicator
Another steps:
Discarding changes
Cannot discard some changesIt happened once or twice but I couldn't find the exact steps right now. If it happens again, I'll write it. |
So this seems to be a particular issue of the blocks field? Have you experienced the same with other fields? |
@distantnative I wouldn't add the old lab example to be honest. |
@bastianallgeier I think you're right. Seems some locking process broken with blocks field. |
I've done few more tests. I guess it's related with |
@afbora that makes sense. We had so many issues with the writer before. If I remember correctly, it's the way that the input event is triggered in the writer field. It doesn't only happen when you type something, it also happens when the value is updated via JS from the backend. That basically creates a wrong additional event. |
e582429
to
e95b22f
Compare
Description
Summary of changes
k-dropdown-content
exposesitems
as scoped default slotk-dropdown-content
has newitem
scoped slot