Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes #6795

Merged
merged 309 commits into from
Nov 20, 2024
Merged

Changes #6795

merged 309 commits into from
Nov 20, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 14, 2024 •
edited
Loading

Known problems

  • content.js: watcher for api endpoint changes calls save request on initial load (should be avoided) and when the API endpoint has already changed
    • the save request goes to the new model, not the old one that it actually applies to
  • FormControls: fix error for preview prop type #6796

Todo

Changelog (in the making)

Features

  • Unsaved changes are stored as changes version on the server
  • Preview Panel view for changes version

Breaking changes

  • All lock routes have been removed
  • Removed Vuex and this.$store
  • Removed k-form-buttons

distantnative and others added 30 commits October 4, 2024 16:01
@distantnative
Merge branch 'v5/develop' into v5/changes/develop
3ba1919
@distantnative
cs tweaks
3ff4b01
@bastianallgeier
Merge branch 'v5/develop' into v5/changes/develop
4aa69e9
@bastianallgeier
Fix date in lab example
c16a57f
@bastianallgeier
Extend form controls to show the dropdown for unsaved changes
aab9769
@bastianallgeier
Pass the changes URL to the page and site views
8946eca
@bastianallgeier
Set the lock modification date on update
3f125bf
@bastianallgeier
Wrap the form controls in div to avoid display issues and accept a da…
03cd0cd 
…te object as modified time
@bastianallgeier
Pass the changes URL to the form controls
3386f93
@bastianallgeier
Change the modification timestamp only after the save request went th…
9d73e97 
…rough
@distantnative
Try fixing CI
adf1912
@bastianallgeier
Merge pull request #6727 from getkirby/v5/changes/preview
71f77c6 
New dropdown with preview button
@distantnative
Rename storage handler classes
4706f0a
@bastianallgeier
Merge pull request #6730 from getkirby/v5/changes/rename-storage
c966bb5 
Rename storage handler classes
@bastianallgeier
Remove tracking from the controller and fix the language
4d5c1db
@bastianallgeier
Make sure to get the changes for the current language
c625cb8
@bastianallgeier
New wildcard for the Version::exists method and improved field handli…
0a54912 
…ng and tracking
@bastianallgeier
Remove unnecessary tracking
ea53fe6
@bastianallgeier
Add new test to fetch changes
a24df74
@bastianallgeier
Merge pull request #6732 from getkirby/v5/changes/multi-language
937649e 
Multi-language fixes
@distantnative
Merge branch 'v5/develop' into v5/changes/develop
5479f97
@bastianallgeier
Use new changes cache instead of the changes field in the site.txt
4f7d838
@bastianallgeier @distantnative
Simplify the cacheKey method
319b423 
Co-authored-by: Nico Hoffmann  ෴. <me@nhoffmann.com>
@bastianallgeier
Cache the app instance on construct
ae5a953
@bastianallgeier
Merge pull request #6733 from getkirby/v5/changes/changes-cache
a03ec65 
Use new changes cache instead of the changes field in the site.txt
@bastianallgeier
Merge branch 'v5/develop' into v5/changes/develop
48539e4 
# Conflicts:
#	panel/package-lock.json
#	panel/src/components/Views/Users/UserAvatar.vue
#	panel/src/components/Views/Users/UserProfile.vue
#	panel/src/components/Views/Users/UserView.vue
#	src/Panel/User.php
@bastianallgeier
Fix license unit test
308ef27
@bastianallgeier
New ::applyProp method
2bb2e00
@bastianallgeier
Remove signature from FieldClass
7abbe86
@bastianallgeier
New Field::fill method
5bc5414
@bastianallgeier bastianallgeier added this to the 5.0.0-alpha.4 milestone Nov 15, 2024
bastianallgeier and others added 17 commits November 15, 2024 16:05
@bastianallgeier
Fix the status button component
576ca96
@bastianallgeier
Fix the unit test
e56e1ed
@bastianallgeier
Move content module logic into model views
6e70311
@bastianallgeier
Bind api endpoint directly to call
23797fd
@bastianallgeier
Reduce dependency on content module
f0180fc
@bastianallgeier
Keep requests silent
ea291b1
@bastianallgeier
Make all content methods api dependent and add checks
b017ccc
@bastianallgeier
Additional clean up and improvements
cb01126
@bastianallgeier
Fix PreviewView after new computed props
11f3bcb
@bastianallgeier
Improve inline docs and method names
d11d3dd
@bastianallgeier @distantnative
Improve the wording
19a2a55 
Co-authored-by: Nico Hoffmann  ෴. <me@nhoffmann.com>
@bastianallgeier
Rename isUnsaved prop to hasChanges
8d61337
@bastianallgeier
Apply default api endpoint in method calls
1d21613
@bastianallgeier
Call save directly in update method
43de043
@bastianallgeier
Merge pull request #6799 from getkirby/v5/changes/content
700bbe6 
Improvements for the content.js module
@bastianallgeier
Simplify API routes
9f960f3
@bastianallgeier
Improve docblock
a4c6d28
@bastianallgeier bastianallgeier marked this pull request as ready for review November 20, 2024 08:56
@bastianallgeier bastianallgeier merged commit a13ae75 into v5/develop Nov 20, 2024
13 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/develop branch November 20, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-alpha.4
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier