feat(dunning): Stop and reset counters for customers

getlago · Nov 8, 2024 · 347506b · 347506b
1 parent fe3da1a
commit 347506b
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 4 deletions.
diff --git a/app/services/dunning_campaigns/bulk_process_service.rb b/app/services/dunning_campaigns/bulk_process_service.rb
@@ -34,10 +34,7 @@ def call
         return result if max_attempts_reached?
         return result unless days_between_attempts_satisfied?
 
-        DunningCampaigns::ProcessAttemptJob.perform_later(
-          customer: customer,
-          dunning_campaign_threshold: threshold
-        )
+        DunningCampaigns::ProcessAttemptJob.perform_later(customer:, dunning_campaign_threshold: threshold)
 
         result
       end

diff --git a/app/services/dunning_campaigns/create_service.rb b/app/services/dunning_campaigns/create_service.rb
@@ -19,6 +19,15 @@ def call
             .dunning_campaigns
             .applied_to_organization
             .update_all(applied_to_organization: false) # rubocop:disable Rails/SkipsModelValidations
+
+          # NOTE: Stop and reset existing campaigns.
+          organization.customers.where(
+            applied_dunning_campaign_id: nil,
+            exclude_from_dunning_campaign: false
+          ).update_all( # rubocop:disable Rails/SkipsModelValidations
+            last_dunning_campaign_attempt: 0,
+            last_dunning_campaign_attempt_at: nil
+          )
         end
 
         dunning_campaign = organization.dunning_campaigns.create!(

diff --git a/app/services/dunning_campaigns/update_service.rb b/app/services/dunning_campaigns/update_service.rb
@@ -21,6 +21,15 @@ def call
             .applied_to_organization
             .update_all(applied_to_organization: false) # rubocop:disable Rails/SkipsModelValidations
 
+          # NOTE: Stop and reset existing campaigns.
+          organization.customers.where(
+            applied_dunning_campaign_id: nil,
+            exclude_from_dunning_campaign: false
+          ).update_all( # rubocop:disable Rails/SkipsModelValidations
+            last_dunning_campaign_attempt: 0,
+            last_dunning_campaign_attempt_at: nil
+          )
+
           dunning_campaign.applied_to_organization = params[:applied_to_organization]
         end
 

diff --git a/spec/services/dunning_campaigns/create_service_spec.rb b/spec/services/dunning_campaigns/create_service_spec.rb
@@ -106,6 +106,13 @@
                 .to(false)
             end
           end
+
+          it "stops and resets counters on customers" do
+            customer = create(:customer, organization:, last_dunning_campaign_attempt: 1, last_dunning_campaign_attempt_at: Time.current)
+
+            expect { create_service.call }.to change { customer.reload.last_dunning_campaign_attempt }.from(1).to(0)
+              .and change { customer.last_dunning_campaign_attempt_at }.from(a_value).to(nil)
+          end
         end
 
         context "with validation error" do

diff --git a/spec/services/dunning_campaigns/update_service_spec.rb b/spec/services/dunning_campaigns/update_service_spec.rb
@@ -87,6 +87,13 @@
                 .to(false)
             end
           end
+
+          it "stops and resets counters on customers" do
+            customer = create(:customer, organization:, last_dunning_campaign_attempt: 1, last_dunning_campaign_attempt_at: Time.current)
+
+            expect { result }.to change { customer.reload.last_dunning_campaign_attempt }.from(1).to(0)
+              .and change { customer.last_dunning_campaign_attempt_at }.from(a_value).to(nil)
+          end
         end
 
         context "with no dunning campaign record" do