fix(subscription): Make sure terminated invoice always comes with the…

… right boundaries (#2561)

## Context

Some termination invoices failed to refresh or are generated with the
wrong boundaries.
This is related to a small mismatch with the time comparison when
looking if the subscription was terminated before the invoice timestamp.

## Description

This PR fixes the `subscription#terminated_at?` comparison so that it
always compare time with the second precision, to avoid side effects
related to rounding when persisting `ActiveRecord` objects.

A lot of `DateTime` objects are also converted into proper `Time.zone`
to fix potential issues around time management as DateTime should not be
used in Lago's context (see
https://docs.datadoghq.com/code_analysis/static_analysis_rules/ruby-best-practices/no-datetime/)

app/models/invoice.rb

@@ -222,8 +222,8 @@ def recurring_breakdown(fee)
       charge: fee.charge,
       subscription: fee.subscription,
       boundaries: {
-        from_datetime: DateTime.parse(fee.properties['charges_from_datetime']),
-        to_datetime: DateTime.parse(fee.properties['charges_to_datetime']),
+        from_datetime: Time.zone.parse(fee.properties['charges_from_datetime']),
+        to_datetime: Time.zone.parse(fee.properties['charges_to_datetime']),
         charges_duration: fee.properties['charges_duration']
       },
       filters:

app/models/subscription.rb

@@ -169,7 +169,11 @@ def terminated_at?(timestamp)
     return false unless terminated?
     return false if terminated_at.nil? || timestamp.nil?
 
-    terminated_at <= timestamp
+    # TODO: should be cleaued up to only use Time
+    timestamp = timestamp.to_time if [Date, DateTime, String].include?(timestamp.class)
+    timestamp = Time.zone.at(timestamp) if timestamp.is_a?(Integer)
+
+    terminated_at.round <= timestamp.round
   end
 end
 

app/services/fees/create_true_up_service.rb

@@ -51,7 +51,7 @@ def date_service
 
       @date_service ||= Subscriptions::DatesService.new_instance(
         subscription,
-        boundaries.timestamp || Time.current,
+        boundaries.timestamp ? Time.zone.parse(boundaries.timestamp) : Time.current,
         current_usage: subscription.terminated? && subscription.upgraded?
       )
     end

app/services/invoices/create_invoice_subscription_service.rb

@@ -133,7 +133,7 @@ def invoicing_reason_for_subscription(subscription)
       # NOTE: upgrading is used as a not persisted reason as it means
       #       one subscription starting and a second one terminating
       return invoicing_reason if invoicing_reason.to_sym != :upgrading
-      return :subscription_terminating if subscription.terminated? && subscription.terminated_at <= timestamp
+      return :subscription_terminating if subscription.terminated_at?(timestamp)
 
       :subscription_starting
     end