fix(subscription): Make sure terminated invoice always comes with the right boundaries #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudded
reviewed
Sep 10, 2024
rsempe
approved these changes
Sep 10, 2024
vincent-pochet
force-pushed
the
fix-terminated-at
branch
from
03ba6f2 to
aa9d6de
Compare
… right boundaries
vincent-pochet
force-pushed
the
fix-terminated-at
branch
from
aa9d6de to
6cb98da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some termination invoices failed to refresh or are generated with the wrong boundaries.
This is related to a small mismatch with the time comparison when looking if the subscription was terminated before the invoice timestamp.
Description
This PR fixes the
subscription#terminated_at?comparison so that it always compare time with the second precision, to avoid side effects related to rounding when persistingActiveRecordobjects.A lot of
DateTimeobjects are also converted into properTime.zoneto fix potential issues around time management as DateTime should not be used in Lago's context (see https://docs.datadoghq.com/code_analysis/static_analysis_rules/ruby-best-practices/no-datetime/)