Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): Add validation rule on rate_amount #2547

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix(wallet): Add validation rule on rate_amount #2547

merged 1 commit into from
Sep 9, 2024

Conversation

vincent-pochet
Copy link
Collaborator

Context

This PR adds a validation rule to wallet#rate_amount to make sure it will always be a positive value.

It will fixes the following dead job related to wallets with rate_amount = 0

ActiveRecord::RecordInvalid

Validation failed: Ongoing balance is not a number, Ongoing usage balance is not a number (ActiveRecord::RecordInvalid)

@vincent-pochet vincent-pochet added the 🐞 Bug Something isn't working label Sep 9, 2024
@vincent-pochet vincent-pochet merged commit 963f4b2 into main Sep 9, 2024
6 checks passed
@vincent-pochet vincent-pochet deleted the fix-wallet-validation branch September 9, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annvelents annvelents annvelents approved these changes

@nudded nudded nudded approved these changes

Assignees
No one assigned
Labels
🐞 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincent-pochet @nudded @annvelents