Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Add validation rule on rate_amount #2547

Merged
merged 1 commit into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/models/wallet.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ class Wallet < ApplicationRecord
monetize :balance_cents, :ongoing_balance_cents, :ongoing_usage_balance_cents
monetize :consumed_amount_cents

validates :rate_amount, numericality: {greater_than: 0}

STATUSES = [
:active,
:terminated
Expand Down
4 changes: 4 additions & 0 deletions spec/models/wallet_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
RSpec.describe Wallet, type: :model do
subject(:wallet) { build(:wallet) }

describe 'validations' do
it { is_expected.to validate_numericality_of(:rate_amount).is_greater_than(0) }
end

describe 'currency=' do
it 'assigns the currency to all amounts' do
wallet.currency = 'CAD'
Expand Down