Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where upload progress was not shown in FormAttachmentPopups #954

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

matthew-white
Copy link
Member

Closes getodk/central#606. The issue is that the event passed to the onUploadProgress callback no longer has a lengthComputable property. I've filed an issue about that at axios/axios#6290. However, the event now has a convenient progress property that we can use instead.

What has been done to verify that this works as intended?

It's difficult to write a test for this change for reasons described at #127 (comment). However, I verified the change locally.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white requested a review from ktuite March 11, 2024 19:38
@matthew-white matthew-white merged commit 5d109f5 into master Mar 12, 2024
1 check passed
@matthew-white matthew-white deleted the form-attachment-progress branch March 12, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Attachments page does not show upload progress
2 participants