Fix bug where upload progress was not shown in FormAttachmentPopups #954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#606. The issue is that the event passed to the
onUploadProgress
callback no longer has alengthComputable
property. I've filed an issue about that at axios/axios#6290. However, the event now has a convenientprogress
property that we can use instead.What has been done to verify that this works as intended?
It's difficult to write a test for this change for reasons described at #127 (comment). However, I verified the change locally.
Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes