Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form Attachments page does not show upload progress #606

Closed
matthew-white opened this issue Mar 11, 2024 · 2 comments · Fixed by getodk/central-frontend#954
Closed

Form Attachments page does not show upload progress #606

matthew-white opened this issue Mar 11, 2024 · 2 comments · Fixed by getodk/central-frontend#954
Assignees
@matthew-white
Labels
behavior verified Behavior has been manually verified bug frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

matthew-white commented Mar 11, 2024 •
edited
Loading

Problem description

While a form attachment is being uploaded from the Form Attachments page, a pop-up is shown that indicates what percent of the file has been sent. However, currently the percentage is always 0%.

Steps to reproduce the problem

  1. Navigate to the Form Attachments page.
  2. Upload a large file and/or simulate a slow connection. Try something that keeps the pop-up visible for at least 10 seconds. I uploaded an 800 kB file while simulating slow 3G, and the upload took 15 seconds.
  3. Observe that the percentage never changes: it is 0% throughout the upload.

Expected behavior

I expect the percentage to increase over the course of the upload.

Central version

I think this was introduced in v2023.5 when we updated axios (getodk/central-frontend#917).
@matthew-white matthew-white added bug frontend Requires a change to the UI needs testing Needs manual testing labels Mar 11, 2024
@matthew-white matthew-white self-assigned this Mar 11, 2024
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Mar 11, 2024
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Mar 11, 2024
matthew-white added a commit to getodk/central-frontend that referenced this issue Mar 11, 2024
@matthew-white
Fix bug where upload progress was not shown in FormAttachmentPopups
ef99557 
Closes getodk/central#606.
This was referenced Mar 11, 2024
Merged
Closed
matthew-white added a commit to getodk/central-frontend that referenced this issue Mar 12, 2024
@matthew-white
Fix bug where upload progress was not shown in FormAttachmentPopups (#…
5d109f5 
…954)

Closes getodk/central#606.
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Mar 12, 2024
@matthew-white
Copy link
Member Author

@getodk/testers, this issue should now be fixed on staging.

@dbemke
Copy link

dbemke commented Mar 13, 2024

Tested with success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-white matthew-white

Labels
behavior verified Behavior has been manually verified bug frontend Requires a change to the UI
Projects
ODK Central
Status: ✅ done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug where upload progress was not shown in FormAttachmentPopups getodk/central-frontend
2 participants
@matthew-white @dbemke