Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by update conflicts in Entity table #503

Closed
matthew-white opened this issue Sep 26, 2023 · 7 comments
Closed

Filter by update conflicts in Entity table #503

matthew-white opened this issue Sep 26, 2023 · 7 comments
Assignees
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified design verified Verified by a designer enhancement New feature or behavior entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@matthew-white
Copy link
Member

matthew-white commented Sep 26, 2023

See the story in the release criteria.

Frontend PR: getodk/central-frontend#874
Backend PR: getodk/central-backend#1024

@matthew-white matthew-white added enhancement New feature or behavior backend Requires a change to the API server frontend Requires a change to the UI needs testing Needs manual testing needs design review Needs verification from designer entities Multiple Encounter workflows labels Sep 26, 2023
@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Sep 26, 2023
@matthew-white matthew-white removed the needs design review Needs verification from designer label Sep 26, 2023
@matthew-white matthew-white self-assigned this Sep 28, 2023
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Sep 29, 2023
@matthew-white
Copy link
Member Author

matthew-white commented Oct 10, 2023

Things that Backend will need to do:

@sadiqkhoja sadiqkhoja self-assigned this Oct 10, 2023
matthew-white added a commit to getodk/central-frontend that referenced this issue Oct 16, 2023
@matthew-white matthew-white added the needs design review Needs verification from designer label Oct 29, 2023
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Oct 30, 2023
@issa-tseng
Copy link
Member

looks good. it would be nice someday if when it's "1 of x" in the filter dropdown just show the selected option (truncated if too long).

@matthew-white
Copy link
Member Author

That's definitely doable (and configurable per filter). In this case, "Possible conflict" is relatively long, and if we make the filter wide enough for it, there will be a fair amount of unused space in the "2 of 2" case. Is that OK?

Screen Shot 2023-11-27 at 10 56 39 AM

On the submissions page, I don't think we'd want to make those filters any wider, since there's a lot going on in that row. I could still make the submitter filter and the review state filter show the one selected option, but it'd often be truncated.

@dbemke
Copy link

dbemke commented Nov 28, 2023

The expected design for the conflict status filtering is this?

Image

not the one from release criteria ( different text in the conflict status field + show columns filter)?

Image

@matthew-white
Copy link
Member Author

@dbemke, yes, that's currently expected. "Conflict status" will be shown below the filter, not within it. We also haven't added a column selection dropdown yet (and won't as part of this release).

@dbemke
Copy link

dbemke commented Nov 30, 2023

Tested with success!

1 similar comment
@srujner
Copy link

srujner commented Nov 30, 2023

Tested with success!

@srujner srujner added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Nov 30, 2023
@matthew-white matthew-white added design verified Verified by a designer and removed needs design review Needs verification from designer labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires a change to the API server behavior verified Behavior has been manually verified design verified Verified by a designer enhancement New feature or behavior entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

No branches or pull requests

5 participants