-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): change the prerelease logic #743
Conversation
✅ Linked to Story DT-4238 · change logic for prerelease |
Link to code coverage report (posted by coverbot 🤖) |
9b6a4f8
to
10da39a
Compare
Link to code coverage report (posted by coverbot 🤖) |
orbs/shared/jobs/pre-release.yaml
Outdated
condition: << parameters.dryrun >> | ||
steps: | ||
- run: | ||
name: Pre-elease (Dry-run) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
name: Pre-elease (Dry-run) | |
name: Pre-release (dry run) |
orbs/shared/jobs/release.yaml
Outdated
@@ -1,4 +1,4 @@ | |||
description: Releases a new version of the application | |||
description: Pre-releases a new version of the application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: isn't this a stable release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this job is for stable release. Will correct the description in the pre-release job.
shell/ci/release/pre-release.sh
Outdated
# Read the GH_TOKEN from the file | ||
GH_TOKEN="$(cat "$HOME/.outreach/github.token")" | ||
if [[ -z $GH_TOKEN ]]; then | ||
echo "Failed to read Github personal access token" >&2 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: according to this, ~/.outreach/github.token
is the legacy path:
devbase/shell/ci/auth/github.sh
Lines 24 to 26 in 060fbed
# Configure the legacy path | |
mkdir -p "$HOME/.outreach" | |
echo "$GITHUB_TOKEN" >"$HOME/.outreach/github.token" |
You should be using gh auth token
, I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I updated to use gh auth token
.
releaseUsername="Outreach CI" | ||
releaseUseremail="outreach-ci@outreach.io" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: perhaps the default values for this should be in the box config. We should avoid Outreach-specific values in this repo since it's public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I've made it configurable from service.yaml. Will also add the default value in box config.
shell/ci/release/dryrun.sh
Outdated
@@ -44,6 +44,6 @@ fi | |||
|
|||
GH_TOKEN="$GH_TOKEN" yarn --frozen-lockfile semantic-release --dry-run | |||
|
|||
# Handle unstable releasing for CLIs, pre-conditions for this exist | |||
# Handle prerelease releasing for CLIs, pre-conditions for this exist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
# Handle prerelease releasing for CLIs, pre-conditions for this exist | |
# Handle prereleases for CLIs, pre-conditions for this exist |
Link to code coverage report (posted by coverbot 🤖) |
2 similar comments
Link to code coverage report (posted by coverbot 🤖) |
Link to code coverage report (posted by coverbot 🤖) |
Link to code coverage report (posted by coverbot 🤖) |
2 similar comments
Link to code coverage report (posted by coverbot 🤖) |
Link to code coverage report (posted by coverbot 🤖) |
16f2098
to
bdfec96
Compare
Link to code coverage report (posted by coverbot 🤖) |
Link to code coverage report (posted by coverbot 🤖) |
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
Need to run |
Thanks, fixed the format. |
🎉 This PR is included in version 2.27.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* fix(stencil): upgrade modules (2024-04-16) (#768) * fix(stencil): upgrade modules (2024-04-16) * Update .circleci/config.yml Co-authored-by: Mark Lee <malept@users.noreply.github.com> * Update package.json Co-authored-by: Mark Lee <malept@users.noreply.github.com> * update yarn.lock --------- Co-authored-by: getoutreach-ci-1[bot] <95656460+getoutreach-ci-1[bot]@users.noreply.github.com> Co-authored-by: Phil Brocker <5331286+pbr0ck3r@users.noreply.github.com> Co-authored-by: Mark Lee <malept@users.noreply.github.com> Co-authored-by: Devbase CI <phil.brocker@outreach.io> * chore: revert semantic-release dependency bumps (#769) * chore: add cortex.yaml (#770) * chore: add cortex.yaml * remove opslevel * fix(release-dryrun): CI-specific commands; use gh (#772) * fix(release-dryrun): only setup git user name/email in CI * refactor(release-dryrun): use gh for GitHub token * feat: add `make stencil` and `make restencil` (#771) * chore(deps): bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 (#773) Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.3 to 1.3.7. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.3.3...v1.3.7) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: add catalog sync script, used when catalog manifest isn't a template (#774) * feat(coverbot): update version of coverbot to v1.0.5 (#775) * fix: bump kubeconform to 0.6.4 (#777) * fix: replace vulnerable, unmaintained dependency with a fixed, maintained fork (#779) * fix(go): parse HTTPS git URLs correctly (#780) * feat(release): change the prerelease logic (#743) * feat(release): change the prerelease logic * fix: typo * fix: linter * fix: remove testing lines * fix: add comments * fix: add script and orb to trigger rc release * fix: set branch to current if it is null * fix: comments and remove testing lines * fix: address comments * fix: force to trigger release for testing access token * fix: config release uer in service.yaml and default in box * fix: revert testing * fix: linter * fix: box config for release user * fix: use GH_TOKEN * fix: allow partial match the commit message * fix: skip release dryrun for empty change * use gh auth Co-authored-by: Mark Lee <malept@users.noreply.github.com> * update description Co-authored-by: Mark Lee <malept@users.noreply.github.com> * fix format --------- Co-authored-by: Devbase CI <devbase@outreach.io> Co-authored-by: Mark Lee <malept@users.noreply.github.com> * chore(deps): bump github.com/getoutreach/localizer from 1.15.3 to 1.15.4 (#778) * chore(deps): bump github.com/getoutreach/localizer from 1.15.3 to 1.15.4 Bumps [github.com/getoutreach/localizer](https://github.com/getoutreach/localizer) from 1.15.3 to 1.15.4. - [Release notes](https://github.com/getoutreach/localizer/releases) - [Changelog](https://github.com/getoutreach/localizer/blob/main/.releaserc.yaml) - [Commits](getoutreach/localizer@v1.15.3...v1.15.4) --- updated-dependencies: - dependency-name: github.com/getoutreach/localizer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Restencil --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: --global <mark.lee@outreach.io> Co-authored-by: Mark Lee <malept@users.noreply.github.com> * fix(linters): prettier 3+ log level flag compatibility (#781) * fix: rc prerelease before unstable release (#783) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: getoutreach-ci-1[bot] <95656460+getoutreach-ci-1[bot]@users.noreply.github.com> Co-authored-by: Phil Brocker <5331286+pbr0ck3r@users.noreply.github.com> Co-authored-by: Mark Lee <malept@users.noreply.github.com> Co-authored-by: Devbase CI <phil.brocker@outreach.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jan Pecek <jan.pecek@outreach.io> Co-authored-by: Devbase CI <devbase@outreach.io> Co-authored-by: --global <mark.lee@outreach.io>
🎉 This PR is included in version 2.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
unstable
andrc
versions, and release branch for stable version.Jira ID
DT-4238 DT-4241
Notes for your reviewers