fix(go): parse HTTPS git URLs correctly #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Bug DT-4333 · make failed in devspace pod to parse git origin url |
yj-yan
approved these changes
Apr 24, 2024
|
🎉 This PR is included in version 2.27.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
yj-yan
added a commit
that referenced
this pull request
May 20, 2024
* fix(stencil): upgrade modules (2024-04-16) (#768) * fix(stencil): upgrade modules (2024-04-16) * Update .circleci/config.yml Co-authored-by: Mark Lee <malept@users.noreply.github.com> * Update package.json Co-authored-by: Mark Lee <malept@users.noreply.github.com> * update yarn.lock --------- Co-authored-by: getoutreach-ci-1[bot] <95656460+getoutreach-ci-1[bot]@users.noreply.github.com> Co-authored-by: Phil Brocker <5331286+pbr0ck3r@users.noreply.github.com> Co-authored-by: Mark Lee <malept@users.noreply.github.com> Co-authored-by: Devbase CI <phil.brocker@outreach.io> * chore: revert semantic-release dependency bumps (#769) * chore: add cortex.yaml (#770) * chore: add cortex.yaml * remove opslevel * fix(release-dryrun): CI-specific commands; use gh (#772) * fix(release-dryrun): only setup git user name/email in CI * refactor(release-dryrun): use gh for GitHub token * feat: add `make stencil` and `make restencil` (#771) * chore(deps): bump github.com/cloudflare/circl from 1.3.3 to 1.3.7 (#773) Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.3.3 to 1.3.7. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.3.3...v1.3.7) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: add catalog sync script, used when catalog manifest isn't a template (#774) * feat(coverbot): update version of coverbot to v1.0.5 (#775) * fix: bump kubeconform to 0.6.4 (#777) * fix: replace vulnerable, unmaintained dependency with a fixed, maintained fork (#779) * fix(go): parse HTTPS git URLs correctly (#780) * feat(release): change the prerelease logic (#743) * feat(release): change the prerelease logic * fix: typo * fix: linter * fix: remove testing lines * fix: add comments * fix: add script and orb to trigger rc release * fix: set branch to current if it is null * fix: comments and remove testing lines * fix: address comments * fix: force to trigger release for testing access token * fix: config release uer in service.yaml and default in box * fix: revert testing * fix: linter * fix: box config for release user * fix: use GH_TOKEN * fix: allow partial match the commit message * fix: skip release dryrun for empty change * use gh auth Co-authored-by: Mark Lee <malept@users.noreply.github.com> * update description Co-authored-by: Mark Lee <malept@users.noreply.github.com> * fix format --------- Co-authored-by: Devbase CI <devbase@outreach.io> Co-authored-by: Mark Lee <malept@users.noreply.github.com> * chore(deps): bump github.com/getoutreach/localizer from 1.15.3 to 1.15.4 (#778) * chore(deps): bump github.com/getoutreach/localizer from 1.15.3 to 1.15.4 Bumps [github.com/getoutreach/localizer](https://github.com/getoutreach/localizer) from 1.15.3 to 1.15.4. - [Release notes](https://github.com/getoutreach/localizer/releases) - [Changelog](https://github.com/getoutreach/localizer/blob/main/.releaserc.yaml) - [Commits](getoutreach/localizer@v1.15.3...v1.15.4) --- updated-dependencies: - dependency-name: github.com/getoutreach/localizer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Restencil --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: --global <mark.lee@outreach.io> Co-authored-by: Mark Lee <malept@users.noreply.github.com> * fix(linters): prettier 3+ log level flag compatibility (#781) * fix: rc prerelease before unstable release (#783) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: getoutreach-ci-1[bot] <95656460+getoutreach-ci-1[bot]@users.noreply.github.com> Co-authored-by: Phil Brocker <5331286+pbr0ck3r@users.noreply.github.com> Co-authored-by: Mark Lee <malept@users.noreply.github.com> Co-authored-by: Devbase CI <phil.brocker@outreach.io> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jan Pecek <jan.pecek@outreach.io> Co-authored-by: Devbase CI <devbase@outreach.io> Co-authored-by: --global <mark.lee@outreach.io>
|
🎉 This PR is included in version 2.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes the case where HTTPS URLs sometimes weren't being parsed correctly.
Jira ID
DT-4333