chore: skip writing to GITHUB_ENV when building formula #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpiffyEight77
force-pushed
the
chore/skip-github-env-write
branch
2 times, most recently
from
401fd99
to
f0c8b7d
Compare
Signed-off-by: Ruihua Wen <spiffyeight77@gmail.com>
SpiffyEight77
force-pushed
the
chore/skip-github-env-write
branch
from
f0c8b7d
to
f31d018
Compare
|
@SpiffyEight77 Thanks for the PR. It looks good to me. Have you been able to test that it works with this change in Homebrew? |
@kichristensen I've tested it in the homebrew-core CI, and it has passed the formula building step. Once this PR is merged and the formula submission for porter is complete, I'd like to explore how to inject an environment variable into the Trivy CI(It seems that the environment variable version will be used.) to make it more flexible. |
|
@schristoff It looks good to me, but you might have some insights into the different flows used? |
schristoff
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chore: skip writing to GITHUB_ENV when building formula
Issue
I'm working on the add brew tap for porter #3045, It appears that the CI process in
homebrew-coredoes not permit writing toGITHUB_ENV.This restriction leads to a panic when building formulas.
As a workaround, I skip writing to
GITHUB_ENVwhen building formulas by detecting whether the repository isHomebrew/homebrew-core.