-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add brew tap for porter #3045
Comments
I started taking a look into this, but we first need to fix the building from the .tar.gz file (#3064) as the formula I'm attempting to create fails at this stage. |
I started looking at this issue as per the last standup. |
Hi @neeginotra, I made a quick start on this, but got quite quickly blocked by the inability to build the project from source. If it's of any use to you, here was my formula. I never got as far as verifying if the format was right for the test section, as the install fell over. # Documentation: https://docs.brew.sh/Formula-Cookbook
# https://rubydoc.brew.sh/Formula
# PLEASE REMOVE ALL GENERATED COMMENTS BEFORE SUBMITTING YOUR PULL REQUEST!
class Porter < Formula
desc "Porter enables you to package your application artifact, client tools, configuration and deployment logic together as an installer that you can distribute, and install with a single command."
homepage "https://porter.sh"
url "https://github.com/getporter/porter/archive/refs/tags/v1.0.17.tar.gz"
sha256 "5262251aba930331b0e3b83cb971f6d138611b37b81af621606b6578739b5e9a"
license "Apache-2.0"
depends_on "go" => :build
def install
system "go", "run", "mage.go", "Build"
end
test do
assert_match "1.0.17", shell_output("#{bin}/porter version")
end
end D |
hello @dgannon991 |
Hey @neeginotra |
Sorry to bother you at this moment. 🙇🏻♂️ First of all, thank you for providing the basic formula script by @dgannon991. This script has been very helpful to me. To verify the formula construction, I fork this repository and updated the magefiles dependency to version 0.6.5. I executed the following command on my local machine and it worked, but there is still a minor issue when running the version command.
If I build from the specified commit as shown below, everything will work well.
We need to submit the script mentioned above which build from the source code without git, following the rule of homebrew contribution. Here is the draft PR #171414 for this formula issue. I plan to fix the version command issue caused by magefiles, and then wait for the new version of porter to be released, where the magefiles version is the latest. Finally, I will update the URL in the script to the official repository and submit the formula to homebrew-core. I'm highly interested in this matter and actively working on it. Could you @schristoff kindly assign it to me? 🙇🏻♂️ |
@SpiffyEight77 Not a bother at all. I look forward to your PR. Thank you so much :) |
Sorry to bother you. This task is nearly complete. Should I wait for the v1.1.0 release before resubmitting the formula? Additionally, I'd like to create a new issue to track the problem of writing environment variables into GHA for the Trivy CI. I hope to make it more flexible and remove the hardcoding that skips writing during building formula. By the way, I've opened a new issue to discuss various installation methods for Porter across different Linux distributions. I'd like to hear your thoughts on this. 🙇🏻♂️ |
Hey @SpiffyEight77 - I think it would be great for Porter to be in multiple package managers, but only if we have an automated way to keep releases up to date with all of them! |
@schristoff
I'll try to figure out how to implement this in my free time.
To make sure it works, I suggest to release the latest version v0.6.7 of the Looking forward to your reply. 🙇🏻♂️ |
Hey @SpiffyEight77 - I just cut v1.1.0-rc - expect binaries to be on GH in about an 1hr~ |
@schristoff Unfortunately, homebrew/core is not accept to ship any rc release, so that I'll submit a new PR for v1.1.0-rc to getporter/homebrew later tonight. Once version 1.1.0 is released, I will process the existing PR in Homebrew-core. 🙇🏻♂️ |
🤦♀️🤦♀️🤦♀️🤦♀️ I did not know that |
@schristoff getporter/homebrew offers a pre-release version of Porter for installation. |
@schristoff I forked the repository and attempted to install Porter using the Homebrew tap command, but the installation failed because https://cdn.porter.sh/mixins/atom.xml has not been updated yet.
|
Hey @schristoff, sorry to bother you. The easiest way to pass the CI of The constraints on the mage build are too many, causing me to be stuck in a dead end and I'm so sorry that wasting your time to release the I will submit the PR to revert the change I have made to the magefiles. Please review the PR for If there is no problem for the PR, I will re-request review again.🙇🏻♂️ |
Hey @schristoff @kichristensen, sorry to disturb you right now.
|
@SpiffyEight77 Thanks for getting this through and added to homebrew. We will formulate a plan for handling mixins better in the future, to avoid the challenge with the exec mixin |
Is your feature request related to a problem? Please describe.
Currently, the install process for Mac/others is through shell script. It would be beneficial to have
brew
install tap be created for simpler binary management on mac. Similar tools exist for most other platforms as well.Describe the solution you'd like
A clear and concise description of what you want to happen. Provides information on how to do a cask or formula. However, I believe there is some go tooling that can auto-generate this for a project (still searching for the appropriate doc)
Additional context
The current install script method is error-prone and reliant on multiple updates within the infrastructure; this would simplify it.
The text was updated successfully, but these errors were encountered: