Rename Dockerfile.tmpl to template.Dockerfile #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1rstmehul
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
carolynvs
requested changes
Nov 10, 2021
3 tasks
use `.Dockerfile` file extension to get syntax highlighting in IDEs. Signed-off-by: Parmeshwar Patidar <prm.mehul@gmail.com>
f1rstmehul
force-pushed
the
change-dockerfile-extension
branch
from
e2b921e to
7b98f50
Compare
carolynvs
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Change the generated dockerfile template to use
.Dockerfilefile extension to get syntax highlighting in IDEs.What issue does it fix
Closes #1771
Notes for the reviewer
N/A
Checklist
If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇♀️