Fix build driver experimental flag checks #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two config settings that control which build driver we use: * experimental * build-driver The experimental feature needs to be enabled in order for the build-driver setting to take effect. When I was testing another PR, I realized that in some parts of the code, I was only checking the build-driver setting without making sure the experimental feature was enabled. This adds a function GetBuildDriver to Config that we can use to centralize that logic. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
There are two config settings that control which build driver we use:
The experimental feature needs to be enabled in order for the build-driver setting to take effect. When I was testing another PR, I realized that in some parts of the code, I was only checking the build-driver setting without making sure the experimental feature was
enabled.
This adds a function GetBuildDriver to Config that we can use to centralize that logic.
What issue does it fix
Found this while testing #1817
Notes for the reviewer
N/A
Checklist