Support for version number validation against mixins #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
|
@dgannon991 Yes the format looks like what I thought about. Didn't really think about adding the full semver constraint, but I think it makes sense, and it would allow to later implement logic that could automatically download the right version if needed |
|
Nice. I’ll try and get the other half of it down for Thursday. Cheers! |
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
dgannon991
requested review from
schristoff,
sgettys,
bdegeeter,
troy0820 and
kichristensen
as code owners
Signed-off-by: David Gannon <19214156+dgannon991@users.noreply.github.com>
kichristensen
approved these changes
Sep 21, 2024
dgannon991
deleted the
feat/3136/mixin-version-support-second-attempt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Added a check on version numbers if specified in your porter YAML
What issue does it fix
Delivers towards #3136
Notes for the reviewer
@kichristensen - this is just a draft to make sure I'd got the right idea, before adding the checks into the linting side. I was fairly sure I'd understood, but thought it was worth double checking as it's been a little while :)