Add forked to indicator to query #37

shayelkin · 2013-11-02T21:06:23Z

Shows where a query was forked to an from (my first time writing both django and angular: apologies if I'm not doing it right)

Add "parent_id" field to show where a query was cloned from
Add parent and forked queries to query (fiddle) screen

* Add "parent_id" field to show where a query was cloned from, * Add parent and forked queries to query (fiddle) screen

arikfr · 2013-11-07T18:10:30Z

rd_service/data/models.py

@@ -43,12 +43,13 @@ class Query(models.Model):
    ttl = models.IntegerField()
    user = models.CharField(max_length=360)
    created_at = models.DateTimeField(auto_now_add=True)
+    parent = models.ForeignKey('self', related_name='forked')


related_name should be forks, no?

server.py: forks and parent_name in query_def confuse django. (this only happnes with the non-minimized verison. Worth investigating in the future?)

arikfr · 2015-07-20T16:47:04Z

I was keeping this pull request open as a reminder to implement this functionality, but realized that I won't do it any time soon, and it started to become ridiculous. So with heavy heart, I'm closing this...

Sorry, @shayel.

In the long run we'll be able to install additional dependencies by having an own Dockerfile to build images based on the Redash image but that installs additional Python dependencies. But until we have a fork with lots of changes ourselves we need to do it this way. Redash-stmo contains the ability to hook up our own Dockerflow library. Refs getredash#13 Refs getredash#37

…dash#311) Extend the Remote User Auth backend with the ability to pass remote user groups via a configurable request header similar to the REMOTE_USER header. Refs getredash#37. If enabled the feature allows checks the header value against a configured list of group names, including the ability to use UNIX shell-style wildcards.

In the long run we'll be able to install additional dependencies by having an own Dockerfile to build images based on the Redash image but that installs additional Python dependencies. But until we have a fork with lots of changes ourselves we need to do it this way. Redash-stmo contains the ability to hook up our own Dockerflow library. Refs getredash#13 Refs getredash#37

…dash#311) Extend the Remote User Auth backend with the ability to pass remote user groups via a configurable request header similar to the REMOTE_USER header. Refs getredash#37. If enabled the feature allows checks the header value against a configured list of group names, including the ability to use UNIX shell-style wildcards.

In the long run we'll be able to install additional dependencies by having an own Dockerfile to build images based on the Redash image but that installs additional Python dependencies. But until we have a fork with lots of changes ourselves we need to do it this way. Redash-stmo contains the ability to hook up our own Dockerflow library. Refs getredash#13 Refs getredash#37

…dash#311) Extend the Remote User Auth backend with the ability to pass remote user groups via a configurable request header similar to the REMOTE_USER header. Refs getredash#37. If enabled the feature allows checks the header value against a configured list of group names, including the ability to use UNIX shell-style wildcards.

In the long run we'll be able to install additional dependencies by having an own Dockerfile to build images based on the Redash image but that installs additional Python dependencies. But until we have a fork with lots of changes ourselves we need to do it this way. Redash-stmo contains the ability to hook up our own Dockerflow library. Refs #13 Refs getredash#37

…dash#311) Extend the Remote User Auth backend with the ability to pass remote user groups via a configurable request header similar to the REMOTE_USER header. Refs getredash#37. If enabled the feature allows checks the header value against a configured list of group names, including the ability to use UNIX shell-style wildcards.

In the long run we'll be able to install additional dependencies by having an own Dockerfile to build images based on the Redash image but that installs additional Python dependencies. But until we have a fork with lots of changes ourselves we need to do it this way. Redash-stmo contains the ability to hook up our own Dockerflow library. Refs getredash#13 Refs getredash#37

…dash#311) Extend the Remote User Auth backend with the ability to pass remote user groups via a configurable request header similar to the REMOTE_USER header. Refs getredash#37. If enabled the feature allows checks the header value against a configured list of group names, including the ability to use UNIX shell-style wildcards.

In the long run we'll be able to install additional dependencies by having an own Dockerfile to build images based on the Redash image but that installs additional Python dependencies. But until we have a fork with lots of changes ourselves we need to do it this way. Redash-stmo contains the ability to hook up our own Dockerflow library. Refs getredash#13 Refs getredash#37

- Use new master / rc release release strategy (getredash#440) - Migrate Circle CI 2.0 (getredash#488, getredash#502, getredash#923) - Install redash-stmo. In the long run we'll be able to install additional dependencies by having an own Dockerfile to build images based on the Redash image but that installs additional Python dependencies. But until we have a fork with lots of changes ourselves we need to do it this way. Redash-stmo contains the ability to hook up our own Dockerflow library. Disable test that tests the login page and the existence of the remote auth link there. We override this functionality for user experience reasons via redash-stmo and redirect from the login page to the remote auth URL. Refs getredash#13 Refs getredash#37

Add forked to indicator to query

b738fbb

* Add "parent_id" field to show where a query was cloned from, * Add parent and forked queries to query (fiddle) screen

arikfr reviewed Nov 7, 2013
View reviewed changes

Code review comments + fix server.py

4761ed4

server.py: forks and parent_name in query_def confuse django. (this only happnes with the non-minimized verison. Worth investigating in the future?)

arikfr closed this Jul 20, 2015

Ariffirdausazman mentioned this pull request Dec 22, 2023

[Snyk] Fix for 46 vulnerabilities Reflektion/redash#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add forked to indicator to query #37

Add forked to indicator to query #37

shayelkin commented Nov 2, 2013

arikfr Nov 7, 2013

arikfr commented Jul 20, 2015

Add forked to indicator to query #37

Add forked to indicator to query #37

Conversation

shayelkin commented Nov 2, 2013

arikfr Nov 7, 2013

Choose a reason for hiding this comment

arikfr commented Jul 20, 2015