-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forked to indicator to query #37
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,17 @@ <h3 class="panel-title"> | |
<span ng-show="queryResult.getStatus() == 'done'">Rows: {{queryResult.getData().length}} | </span> | ||
Created by: {{query.user}} | ||
<div class="pull-right">Refresh query: <select ng-model="query.ttl" ng-options="c.value as c.name for c in refreshOptions"></select><br></div> | ||
<div ng-show="query.parent_id"> | ||
Duplicated from: <a ng-href="/queries/{{query.parent_id}}">{{query.parent_name}}</a> | ||
</div> | ||
|
||
<div ng-show="query.forks.length"> | ||
Duplicated to: | ||
<span ng-repeat="fork in query.forks"> | ||
<a ng-href="/queries/{{fork.id}}">{{fork.name}}</a> | | ||
</span> | ||
</div> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume you already have examples for this, can you attach a screenshot of how it looks? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (of course, the duplicated from and duplicated to lines only show when they are needed) |
||
|
||
</div> | ||
</div> | ||
|
||
|
@@ -58,4 +69,4 @@ <h3 class="panel-title"> | |
<cohort-renderer query-result="queryResult"></cohort-renderer> | ||
</div> | ||
</div> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove it, then it will never get saved, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. Got it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If something isn't clear on first read, then it should be commented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only unclear without context (the rest of the code). When seen in context it's ok.