Fix dashboard parameter mapping issues #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
reviewed
Oct 4, 2019
ranbena
reviewed
Oct 4, 2019
ranbena
reviewed
Oct 5, 2019
| .click(); | ||
| }; | ||
|
|
||
| it('has widget mapping as the default', function () { |
There was a problem hiding this comment.
The default mapping by API is widget level param (cause api-redash:addWidget doesn't send parameterMapping data), but in the UI (AddWidgetDialog) it's dashboard level param.
Dunno if this is an actual problem or not, but it did confuse me when I read the test.
There was a problem hiding this comment.
Well noticed, I've never realized that 😂. I'll rename the test for now.
ranbena
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Bugs:
null(even though there was a value in the parameter)To-do:
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Issue 1
Before
After
Issue 2
Before
After
