Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Digest (14 October, 2019 - 21 October, 2019) #4271

Closed
weekly-digest bot opened this issue Oct 21, 2019 · 0 comments
Closed

Weekly Digest (14 October, 2019 - 21 October, 2019) #4271

weekly-digest bot opened this issue Oct 21, 2019 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Oct 21, 2019

Here's the Weekly Digest for getredash/redash:


ISSUES

Last week 27 issues were created.
Of these, 14 issues have been closed and 13 issues are still open.

OPEN ISSUES

💚 #4267 Migrate Funnel visualization to React, by kravets-levko
💚 #4266 Migrate PermissionsEditor to React, by gabrieldutra
💚 #4265 Counter Visualization: count rows never shows zero, by susodapop
💚 #4264 Parameter input feedback, by ranbena
💚 #4262 Show worker's current job, by rauchy
💚 #4260 JSON data source doesn't support unicode text in the data field, by myonlylonely
💚 #4258 Fix: Alert condition rendering, by ranbena
💚 #4257 Reduce RQ status load time, by rauchy
💚 #4256 Monitor general RQ queues (default, periodic and schemas), by rauchy
💚 #4254 Give query case sensitive treatment in query hash, by osule
💚 #4251 Migrate the application to Python 3, by NicolasLM
💚 #4248 Counter Visualization: can't format decimal numbers, by susodapop
💚 #4244 Dynamic Snippets, by arikfr

CLOSED ISSUES

❤️ #4268 Add "use-debounce" dependency, by kravets-levko
❤️ #4263 Query Results returns to true when 'False' String, by ayumu838
❤️ #4261 Revert some changes 2to3 tends to do, by jezdez
❤️ #4259 Migrate Sunburst Renderer to React, by kravets-levko
❤️ #4255 Migrate Sankey renderer to React, by kravets-levko
❤️ #4253 Fix/body bottom padding, by ranbena
❤️ #4252 Restore bottom padding, by kravets-levko
❤️ #4250 Fix: Alert page breaks when target query returns null result, by ranbena
❤️ #4249 Alert page breaks when target query returns null result, by susodapop
❤️ #4247 Reset password Error , by raghav111jain
❤️ #4246 Percy snapshot: make sure query results are consistent, by arikfr
❤️ #4245 App Header React migration, by ranbena
❤️ #4243 Fix double-scrollbar when in fullscreen, by stefanmaric
❤️ #4242 Refresh snowflake schema without waking cluster, by Tarun047

LIKED ISSUE

👍 #4244 Dynamic Snippets, by arikfr
It received 👍 x0, 😄 x0, 🎉 x0 and ❤️ x2.

NOISY ISSUE

🔈 #4245 App Header React migration, by ranbena
It received 14 comments.


PULL REQUESTS

Last week, 29 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 2 pull requests were opened.
💚 #4262 Show worker's current job, by rauchy
💚 #4254 Give query case sensitive treatment in query hash, by osule

UPDATED PULL REQUEST

Last week, 12 pull requests were updated.
💛 #4267 Migrate Funnel visualization to React, by kravets-levko
💛 #4266 Migrate PermissionsEditor to React, by gabrieldutra
💛 #4258 Fix: Alert condition rendering, by ranbena
💛 #4257 Reduce RQ status load time, by rauchy
💛 #4256 Monitor general RQ queues (default, periodic and schemas), by rauchy
💛 #4251 Migrate the application to Python 3, by NicolasLM
💛 #4233 Multiprocess RQ workers, by rauchy
💛 #4228 Migrate Dashboard to React, by gabrieldutra
💛 #4175 Migrate Table visualization to React Part 2: Editor, by kravets-levko
💛 #4139 Migrate Chart visualization to React Part 2: Editor, by kravets-levko
💛 #4049 Introduce inheritance to the Parameter structure, by gabrieldutra
💛 #3131 New visualization: Treemap with d3, by deecay

MERGED PULL REQUEST

Last week, 15 pull requests were merged.
💜 #4268 Add "use-debounce" dependency, by kravets-levko
💜 #4261 Revert some changes 2to3 tends to do, by jezdez
💜 #4259 Migrate Sunburst Renderer to React, by kravets-levko
💜 #4255 Migrate Sankey renderer to React, by kravets-levko
💜 #4253 Fix/body bottom padding, by ranbena
💜 #4252 Restore bottom padding, by kravets-levko
💜 #4250 Fix: Alert page breaks when target query returns null result, by ranbena
💜 #4246 Percy snapshot: make sure query results are consistent, by arikfr
💜 #4245 App Header React migration, by ranbena
💜 #4243 Fix double-scrollbar when in fullscreen, by stefanmaric
💜 #4240 Implemented new condition comparison options, by ranbena
💜 #4239 pagerduty.py: Change default summary text, by frextrite
💜 #4231 Avoid depending on app context when templating failure reports, by rauchy
💜 #4211 Fix dashboard parameter mapping issues, by gabrieldutra
💜 #4093 Replace Celery with RQ (except for execute_query tasks), by rauchy


COMMITS

Last week there were 13 commits.
🛠️ Add "use-debounce" dependency (#4268) by kravets-levko
🛠️ App Header React migration (#4245) by ranbena
🛠️ Migrate Sunburst Renderer to React (#4259) by kravets-levko
🛠️ Restore bottom padding (#4252) by kravets-levko
🛠️ Migrate Sankey renderer to React (#4255) by kravets-levko
🛠️ Fix double-scrollbar when in fullscreen (#4243) by stefanmaric
🛠️ [Fix: Alert page breaks when target query returns null result (#4250) * Fix: Alert page breaks when target query returns null result

  • Better handling of topValue value](72bb5d2) by ranbena
    🛠️ [Replace Celery with RQ (except for execute_query tasks) (Replace Celery with RQ (except for execute_query tasks) #4093) * add rq and an rq_worker service

  • add rq_scheduler and an rq_scheduler service

  • move beat schedule to periodic_jobs queue

  • move version checks to RQ

  • move query result cleanup to RQ

  • use timedelta and DRY up a bit

  • move custom tasks to RQ

  • do actual schema refreshes in rq

  • rename 'period_jobs' to 'periodic', as it obviously holds jobs

  • move send_email to rq

  • DRY up enqueues

  • ditch and use a partially applied decorator

  • move subscribe to rq

  • move check_alerts_for_query to rq

  • move record_event to rq

  • make tests play nicely with rq

  • 👋 beat

  • rename rq_scheduler to plain scheduler, now that there's no Celery scheduler entrypoint

  • add some color to rq-worker's output

  • add logging context to rq jobs (while keeping execute_query context via get_task_logger for now)

  • move schedule to its own module

  • cancel previously scheduled periodic jobs. not sure this is a good idea.

  • rename redash.scheduler to redash.schedule

  • allow custom dynamic jobs to be added decleratively

  • add basic monitoring to rq queues

  • add worker monitoring

  • pleasing the CodeClimate overlords

  • adjust cypress docker-compose.yml to include rq changes

  • DRY up Cypress docker-compose

  • add rq dependencies to cypress docker-compose service

  • an odd attempt at watching docker-compose logs when running with Cypress

  • Revert "an odd attempt at watching docker-compose logs when running with Cypress"

This reverts commit 016bd1a.

  • show docker-compose logs at Cypress shutdown

  • Revert "DRY up Cypress docker-compose"

This reverts commit 43abac7.

  • minimal version for binding is 3.2

  • remove unneccesary code reloads on cypress

  • add a command which errors if any of the workers running inside the current machine haven't been active in the last minute

  • SCHEMAS_REFRESH_QUEUE is no longer a required setting

  • split tasks/queries.py to execution.py and maintenance.py

  • fix tests after query execution split

  • pleasing the CodeClimate overlords

  • rename worker to celery_worker and rq_worker to worker

  • use /rq_status instead of /jobs

  • show started jobs' time ago according to UTC

  • replace all spaces in column names

  • fix query tests after execution split

  • exit with an int

  • general lint

  • add an entrypoint for rq_healthcheck

  • fix indentation

  • delete all existing periodic jobs before scheduling them

  • remove some unrequired requires

  • move schedule example to redash.schedule

  • add RQ integration to Sentry's setup

  • pleasing the CodeClimate overlords

  • remove replication settings from docker-compose - a proper way to scale using docker-compose would be the --scale CLI option, which will be described in the knowledge based

  • revert to calling a function in dynamic settings to allow periodic jobs to be scheduled after app has been loaded

  • don't need to depend on context when templating failure reports

  • set the timeout_ttl to double the interval to avoid job results from expiring and having periodic jobs not reschedule

  • whoops, bad merge

  • describe custom jobs and don't actually schedule them

  • fix merge](5a5fdec) by rauchy
    🛠️ [Avoid depending on app context when templating failure reports (Avoid depending on app context when templating failure reports #4231) * don't need to depend on context when templating failure reports

  • extract a render_template function with some docs

  • CodeClimate has really outdone itself this time. Removed a whitespace character in order to fix 2 CodeClimate errors

  • apparently whitespace doesn't count as a character](f6e1470) by rauchy
    🛠️ Make sure query results are consistent (#4246) by arikfr
    🛠️ [pagerduty.py: Change default summary text (pagerduty.py: Change default summary text #4239) * pagerduty.py: Change default summary text

Change is made to use alert name in PagerDuty's alert
destination default summary text instead of
query id and name


CONTRIBUTORS

Last week there were 7 contributors.
👤 kravets-levko
👤 ranbena
👤 stefanmaric
👤 rauchy
👤 arikfr
👤 frextrite
👤 gabrieldutra


STARGAZERS

Last week there were 81 stagazers.
divyaravichandran
liu-song
fx109138
chibisov
FeifeiCat
samanhappy
sulin2018
gulivan
ploce
wuchangping
PauloLaScience
darwinsubramaniam
yelldo
wutao0914
gremito
znyang
leonsong2010
bj0z
Dawnthy
PB-MORE
MihaiValentin
asamo7
AllwynPradip
b17z
nicknystrom
joesparacio
r3ticuli
eviles
dirkzhao621
SDpower
TonicZhang
phoenix911
shellfeel
Tianny
palemium
pjuszczyk
arystan-sw
Plutoyer
zurhan
hujianxing
vane007b
dcHHH
komeme
brefre
nhducit
mindaslab
Dwayneten
torniker
robert-carroll
ZinkLu
xiaogaobo
kSpacer201
TianD
andrewdmeier
LabN36
franzliedke
kevinoliveira
mauriciocordeiro
xtvjxk123456
xiaodin1
onlyphantom
apporoad
triangletodd
hiling
remoharsono
SS-Cat
code-monk08
kevinprince
xgenvn
jj-tay
timetobye
ChengLiu1991
f1soarez
JorgenPhi
cadenceinc
tongji1907
jbgo
jits
pcgeek86
dorianbg
takagishunsuke
You all are the stars! 🌟


RELEASES

Last week there were no releases.


That's all for last week, please 👀 Watch and Star the repository getredash/redash to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant