Migrate Sankey renderer to React #4255
Conversation
kravets-levko
added
Frontend
Visualizations
Frontend: React
kravets-levko
force-pushed
the
migrate-sankey-renderer
branch
from
8e74f1a to
41cba71
Compare
| const links = {}; | ||
| const nodes = []; | ||
|
|
||
| // ANGULAR_REMOVE_ME $$ check is for Angular's internal properties |
There was a problem hiding this comment.
No - sankey may still receive data from Angular part, so these properties may be present there. It will be safe to remove when we'll completely remove Angular itself.
|
|
||
| // wait a bit before taking snapshot | ||
| cy.wait(1000); // eslint-disable-line cypress/no-unnecessary-waiting | ||
| cy.percySnapshot('Visualizations - Sunburst', { widths: [viewportWidth] }); |
There was a problem hiding this comment.
Perhaps you can skip the wait by instead of clicking "Show Data Only", visiting page cy.visit('queries/${id}') and then snap?
There was a problem hiding this comment.
I added this timeout to wait for chart to load a query results data. "Show Data Only" is actually a link, so it should be completely equal to cy.visit(...). But I may give it a try
There was a problem hiding this comment.
Seems there is no difference - cy.visit need cy.wait as well. I prefer to keep current variant because 1) it already works 2) it's a bit simpler 🙂
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
#3301 (Migrate Visualizations to React -> Sankey)
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
No visual changes