Fix: Alert condition rendering #4258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made getConditionText safer
|
I'm not sure this is worth the extra complexity. Does it feel that important? |
Was thinking that while working on it but I'm undecided. Up to you @arikfr. |
|
Maybe we can settle for fixing only the alert name and leave out template rendering. |
kravets-levko
approved these changes
Oct 19, 2019
There was a problem hiding this comment.
As for me, math operatiors (< / <= / etc.) are good enough. But maybe "human-oriented" names will work better for non-tech people. I approve this PR because code looks fine, but I let you and @arikfr to decide if it should be merged or not.
Closing due to public disinterest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #4240 alert conditions are no longer represented by a textual description but by chars. This caused templating (notification template and alert default name) to render differently.
This is a fix for that.
(Yes, I know there's server-client code duplication #4187)