-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set of improvements and refinements to visualizations after React migration #4382
Set of improvements and refinements to visualizations after React migration #4382
Conversation
010d998
to
70b9dc8
Compare
d98a467
to
3027f29
Compare
a82255a
to
0ed194c
Compare
0ed194c
to
94e5ac1
Compare
@arikfr @gabrieldutra I touched a lot of files, but I tried to do one change per commit, so you can check commits one by one to see what I did here. |
All the help links that refer to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code + Percy changes look good to me 👌
client/app/components/visualizations/editor/withControlLabel.jsx
Outdated
Show resolved
Hide resolved
@arikfr I updated help icon for number formats - now click on it will open help drawer immediately (also added a tooltip): Also, I updated help icon for date/time formats to match number format one - it's just a link that opens moment.js help: Other context help blocks are unchanged: Also, there are few more places with |
@arikfr If you're fine with this PR - I'd like to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might want to update the tooltips, but no reason to wait with this PR for it. Let's merge.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
#3301