-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inbound Filter Outcome Reason #2850
Comments
Will be fixed by getsentry/sentry#57799. |
This will really help when debugging customer who reach out about data not being in. "My replay is sampled but the error was dropped" and we dunno what filter was applied |
Referencing getsentry/sentry-javascript#10036, as that may be related to this! |
@billyvg also stumbled across this, related to customers calling in and not having enough insight |
Should be straight-forward to port hydration errors to generic filters now, which would give them a separate outcome reason. We just need to extend the |
@smeubank do you have a list of filters we could target? I see special cases for hydration errors and chunk load errors. Getting reasons for these two specifically is quite straightforward. |
After discussing on Slack, the only missing filters without a reason in the above list are the hydration and chunk load errors. |
We are now working on the foundational elements needed to allow the expression of error message rules generically. This is the PR for reference: #3791. The next steps are:
|
Will use this query to validate the new outcomes: MATCH (outcomes)
SELECT reason, count(reason) BY reason
WHERE project_id = 11276 AND org_id = 1
AND outcome = 1
AND timestamp >= toDateTime('2024-07-01T10:30:30')
AND timestamp < toDateTime('2024-07-30T10:30:30') |
Description
We want to be able to categorize why errors dropped by a serverside inound filter are dropped. In this specific case we are trying to analyze the full impact of filtering out hydration errors, but it maybe usefuly to do this in a more scalable way
link
If the filter is based on hyrdation error. Is this included in the "error message" reason? If yes could that be added to the outcome reason? error "message: hydration"
the in product toggle found in project inbound filter settings
The text was updated successfully, but these errors were encountered: