Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule-condition): Add any and all loop conditions #3791

Merged
merged 17 commits into from
Jul 8, 2024

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Jul 4, 2024

This PR adds new rules for any and all behaviors in the RuleCondition DSL. The new rules allow to match on special fields that return iterators of their own Getter implementations.

This work is the foundation for moving existing inbound filters to the generic inbound filters implementation.

@iambriccardo iambriccardo changed the title experimental(rule-condition): Add loop rule condition experimental(rule-condition): Add any and all loop conditions Jul 5, 2024
@iambriccardo iambriccardo marked this pull request as ready for review July 5, 2024 09:31
@iambriccardo iambriccardo requested a review from a team as a code owner July 5, 2024 09:31
@iambriccardo iambriccardo changed the title experimental(rule-condition): Add any and all loop conditions feat(rule-condition): Add any and all loop conditions Jul 5, 2024
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. See minor suggestions for doc comments below.

relay-event-schema/src/protocol/event.rs Outdated Show resolved Hide resolved
relay-protocol/src/condition.rs Outdated Show resolved Hide resolved
relay-protocol/src/condition.rs Outdated Show resolved Hide resolved
relay-protocol/src/condition.rs Outdated Show resolved Hide resolved
relay-protocol/src/traits.rs Outdated Show resolved Hide resolved
relay-protocol/src/traits.rs Outdated Show resolved Hide resolved
relay-protocol/src/traits.rs Outdated Show resolved Hide resolved
relay-protocol/src/traits.rs Outdated Show resolved Hide resolved
relay-protocol/src/value.rs Outdated Show resolved Hide resolved
iambriccardo and others added 10 commits July 5, 2024 13:32
Co-authored-by: Jan Michael Auer <mail@jauer.org>
Co-authored-by: Jan Michael Auer <mail@jauer.org>
Co-authored-by: Jan Michael Auer <mail@jauer.org>
Co-authored-by: Jan Michael Auer <mail@jauer.org>
Co-authored-by: Jan Michael Auer <mail@jauer.org>
Co-authored-by: Jan Michael Auer <mail@jauer.org>
@iambriccardo iambriccardo merged commit 180282b into master Jul 8, 2024
23 checks passed
@iambriccardo iambriccardo deleted the riccardo/feat/generic-filters branch July 8, 2024 07:05
jan-auer added a commit that referenced this pull request Jul 8, 2024
* master:
  feat(getter): Add logentry getter to event (#3796)
  feat(rule-condition): Add `any` and `all` loop conditions (#3791)
  ref(normalization): Remove normalization debug metrics (#3786)
  fix(redis): Fix Redis data corruption on connection timeout (#3792)
  fix(spans): Fixes span outcomes and inherited rate limits (#3793)
  build(py): Update craft to use new manylinux wheels (#3789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants