fix(spans): Fixes span outcomes and inherited rate limits #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/span-outcomes
branch
from
23e430e
to
f5a61fd
Compare
Dav1dde
force-pushed
the
dav1d/span-outcomes
branch
from
f5a61fd
to
983b3a7
Compare
Dav1dde
force-pushed
the
dav1d/span-outcomes
branch
from
983b3a7
to
c434fa7
Compare
jjbayer
approved these changes
Jul 5, 2024
jan-auer
added a commit
that referenced
this pull request
Jul 8, 2024
* master: feat(getter): Add logentry getter to event (#3796) feat(rule-condition): Add `any` and `all` loop conditions (#3791) ref(normalization): Remove normalization debug metrics (#3786) fix(redis): Fix Redis data corruption on connection timeout (#3792) fix(spans): Fixes span outcomes and inherited rate limits (#3793) build(py): Update craft to use new manylinux wheels (#3789)
0Calories
pushed a commit
that referenced
this pull request
Jul 11, 2024
Span outcomes are currently off when created from rate limited transactions in the `transaction_indexed` category. All of the dropped outcomes are also added to the accepted, because the metrics are not dropped. Additionally outcomes for the span category were emitted when there was a limit for `transaction_indexed` instead of just emitting them from `span_indexed`. Implementation notes: Need to drop the metrics based on the enforcement instead of the rate limits, because it is correct that there are no rate limits added for the inherited category. We wouldn't want to start dropping standalone spans because of a transaction quota.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span outcomes are currently off when created from rate limited transactions in the
transaction_indexedcategory. All of the dropped outcomes are also added to the accepted, because the metrics are not dropped.Additionally outcomes for the span category were emitted when there was a limit for
transaction_indexedinstead of just emitting them fromspan_indexed.Implementation notes:
Need to drop the metrics based on the enforcement instead of the rate limits, because it is correct that there are no rate limits added for the inherited category. We wouldn't want to start dropping standalone spans because of a transaction quota.