fix(redis): Fix Redis data corruption on connection timeout #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/redis-timeouts
branch
from
21fa63a
to
d906e9b
Compare
jjbayer
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Any negative side effects expected from this? Nothing can be worse than data corruption, but I'm wondering if there's a performance drawback here. Probably only when we are already in a degraded state, in which case data integrity is still more important than performance.
|
Yes performance will degrade and depend on how many times we run into timeouts, the re-open of the connection is costly. |
jan-auer
added a commit
that referenced
this pull request
Jul 8, 2024
* master: feat(getter): Add logentry getter to event (#3796) feat(rule-condition): Add `any` and `all` loop conditions (#3791) ref(normalization): Remove normalization debug metrics (#3786) fix(redis): Fix Redis data corruption on connection timeout (#3792) fix(spans): Fixes span outcomes and inherited rate limits (#3793) build(py): Update craft to use new manylinux wheels (#3789)
0Calories
pushed a commit
that referenced
this pull request
Jul 11, 2024
Updates Redis to PR redis-rs/redis-rs#1253 which addresses redis-rs/redis-rs#1252 which we've been seeing occasionally in production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Redis to PR redis-rs/redis-rs#1253 which addresses redis-rs/redis-rs#1252 which we've been seeing occasionally in production.
#skip-changelog