feat(inbound-filters): Move filters to generic filters #73840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73840 +/- ##
========================================
Coverage 78.10% 78.10%
========================================
Files 6660 6667 +7
Lines 297718 297609 -109
Branches 51232 51204 -28
========================================
- Hits 232546 232461 -85
+ Misses 58902 58871 -31
- Partials 6270 6277 +7
|
iambriccardo
commented
Jul 9, 2024
src/sentry/ingest/inbound_filters.py
Outdated
|
|
||
| generic_filter = generic_filter_fn() | ||
| if generic_filter is not None: | ||
| generic_filter["id"] = generic_filter_id |
There was a problem hiding this comment.
Decided to put the id here. A bit risky but reduces duplication and arguments of the closures.
jan-auer
reviewed
Jul 9, 2024
src/sentry/ingest/inbound_filters.py
Outdated
Comment on lines
358
to
359
| ("*", "*https://reactjs.org/docs/error-decoder.html?invariant={418,419,422,423,425}*"), | ||
| ("*", "*https://react.dev/errors/{418,419,422,423,425}*"), |
There was a problem hiding this comment.
Ideally, in this case we omit the check for event.exceptions.ty.
jan-auer
approved these changes
Jul 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the first two inbound filters to the new generic filters implementation, namely chunk load errors and hydration errors.
The definition of the new generic filter is very close to the previous hardcoded definition in Relay (for the
errorMessagesinbound filter); however, it differs in the matching of thetyandvalue. In Relay, there is an additional step in which, if bothtyandvalueare set, Relay will try to match the string in the form"{ty}: {value}", which is currently not expressible withRuleConditionconstructs.Our plan is to roll out this implementation and check how many occurrences of the error messages are still going through the old filter and act accordingly.
Closes: getsentry/relay#2850