ref(relay): Update axum-extra and otel-proto libs #3798
Conversation
| "startTimeUnixNano": "1697620454980000000", | ||
| "endTimeUnixNano": "1697620454980078800", |
There was a problem hiding this comment.
Shouldn't we still be able to parse long integers? Even if they get serialized as strings?
There was a problem hiding this comment.
Can you elaborate? Even if they get serialized as strings? -> They are serialized as a string and that works?
There was a problem hiding this comment.
Discussed offline: This will break the OTLP endpoint for old clients that send these values as numbers. We're OK with this breakage because the endpoint is experimental and gated behind a feature flag.
| "startTimeUnixNano": "1697620454980000000", | ||
| "endTimeUnixNano": "1697620454980078800", |
There was a problem hiding this comment.
Discussed offline: This will break the OTLP endpoint for old clients that send these values as numbers. We're OK with this breakage because the endpoint is experimental and gated behind a feature flag.
|
The Rust dependency is now incompatible with the python lib with the same name, protobuf payloads with integers as attributes fail to parse. |
|
Upstream issue for this: open-telemetry/opentelemetry-rust#1905 |
With the changes from here (open-telemetry/opentelemetry-rust#1753), integers are strings now ...
axum-extra update is required for prost 0.12 which is required for the otel dependency.
#skip-changelog