Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable integration test for Span validation #1753

Merged
merged 4 commits into from
May 14, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented May 13, 2024

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner May 13, 2024 21:48
@lalitb lalitb changed the title Enable integration test for traces Enable integration test for Span validation May 13, 2024
@lalitb lalitb added the integration tests Run integration tests label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.6%. Comparing base (348ec9e) to head (9e9932c).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1753     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.5%     
=======================================
  Files        135     136      +1     
  Lines      20751   20845     +94     
=======================================
+ Hits       14746   14934    +188     
+ Misses      6005    5911     -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Though is it expected for the OTLP collector JSON exporter to export int value to string?

@cijothomas cijothomas merged commit 656b1e6 into open-telemetry:main May 14, 2024
20 checks passed
@TommyCpp TommyCpp mentioned this pull request Jun 4, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants