-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of passthrough during BaseResponse construction #558
Allow configuration of passthrough during BaseResponse construction #558
Conversation
please add this change for 0.22 in the log: https://github.com/getsentry/responses/blob/master/CHANGES also, do we need then class attribute ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. It would be good to update the docs and changelog for this.
Good question. I've left it as-is for now for backwards-compatibility, although I have replaced the mention of it in the documentation. Perhaps it could make sense to remove it. Pattern-wise, perhaps we'd want to recommend that |
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
…a superclass constructor argument
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
Thanks @beliaev-maksim! |
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 2561 2581 +20
=========================================
+ Hits 2561 2581 +20
Continue to review full report at Codecov.
|
Thank you 🎉 |
Thanks @markstory! |
Resolves #557.