Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of passthrough during BaseResponse construction #558

Merged
merged 9 commits into from
Jun 13, 2022
Merged

Allow configuration of passthrough during BaseResponse construction #558

merged 9 commits into from
Jun 13, 2022

Conversation

jayaddison
Copy link
Contributor

Resolves #557.

@beliaev-maksim
Copy link
Collaborator

please add this change for 0.22 in the log: https://github.com/getsentry/responses/blob/master/CHANGES

also, do we need then class attribute ?

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. It would be good to update the docs and changelog for this.

@jayaddison
Copy link
Contributor Author

also, do we need then class attribute ?

Good question. I've left it as-is for now for backwards-compatibility, although I have replaced the mention of it in the documentation.

Perhaps it could make sense to remove it. Pattern-wise, perhaps we'd want to recommend that Response objects should be mostly/completely immutable after they are created?

responses/__init__.py Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
CHANGES Outdated Show resolved Hide resolved
responses/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Maksim Beliaev <beliaev.m.s@gmail.com>
@jayaddison
Copy link
Contributor Author

Thanks @beliaev-maksim!

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #558 (580cbac) into master (3d83a88) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #558   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2561      2581   +20     
=========================================
+ Hits          2561      2581   +20     
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d83a88...580cbac. Read the comment docs.

@markstory markstory merged commit b129335 into getsentry:master Jun 13, 2022
@markstory
Copy link
Member

Thank you 🎉

@jayaddison jayaddison deleted the issue-557/provide-baseresponse-constructor-passthrough-kwarg branch June 13, 2022 15:15
@jayaddison
Copy link
Contributor Author

Thanks @markstory!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: allow configuration of passthrough during BaseResponse construction
3 participants