Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of passthrough during BaseResponse construction #558

Merged
merged 9 commits into from
Jun 13, 2022
Merged

Allow configuration of passthrough during BaseResponse construction #558

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e442865
Allow configuration of passthrough during BaseResponse construction
jayaddison May 31, 2022
cf97252
Add changelog entry
jayaddison Jun 7, 2022
660d0aa
Update documentation
jayaddison Jun 7, 2022
923b67b
Require kwarg usage for 'passthrough' constructor argument
jayaddison Jun 7, 2022
381bc3b
Rephrase passthrough argument usage documentation
jayaddison Jun 7, 2022
df5632e
Rephrase changelog entry
jayaddison Jun 7, 2022
64f32f5
Update PassthroughResponse to force passthrough behaviour by passing …
jayaddison Jun 7, 2022
07e628a
Streamline explicit super-constructor call
jayaddison Jun 7, 2022
580cbac
lint fixup: add missing method argument type annotations
jayaddison Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions responses/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,8 @@ def __init__(
url: _URLPatternType,
match_querystring: Union[bool, object] = None,
match: "_MatcherIterable" = (),
*args: Any,
**kwargs: Any,
*,
passthrough: bool = False,
jayaddison marked this conversation as resolved.
Show resolved Hide resolved
) -> None:
self.method: str = method
# ensure the url has a default path set if the url is a string
Expand All @@ -368,8 +368,7 @@ def __init__(

self.match: "_MatcherIterable" = match
self.call_count: int = 0
if "passthrough" in kwargs:
self.passthrough = kwargs["passthrough"]
self.passthrough = passthrough

def __eq__(self, other: Any) -> bool:
if not isinstance(other, BaseResponse):
Expand Down Expand Up @@ -600,7 +599,14 @@ def get_response(self, request: "PreparedRequest") -> HTTPResponse:


class PassthroughResponse(BaseResponse):
passthrough: bool = True
def __init__(
self,
method: str,
url: _URLPatternType,
match_querystring: Union[bool, object] = None,
match: "_MatcherIterable" = (),
):
super().__init__(method, url, match_querystring, match, passthrough=True)
jayaddison marked this conversation as resolved.
Show resolved Hide resolved


class OriginalResponseShim(object):
Expand Down