Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: Incorrect parsing of functional pseudo class css selector (#169)" #182

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Revert "fix: Incorrect parsing of functional pseudo class css selector (#169)" #182

merged 4 commits into from
Apr 19, 2024

Commits on Apr 19, 2024

  1. Revert "fix: Incorrect parsing of functional pseudo class css selector ( 

    #169)"

This reverts commit 810b39f.
    @billyvg
    billyvg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    928280e View commit details
    Browse the repository at this point in the history

  2. Fix for test cases mentioned in rrweb-io#1379 (rrweb-io#1401) 

    * Fix known issues

* Run format

* Fix linting errors

* Add comment in code for source of match logic

* Add changeset
    @dengelke @billyvg
    dengelke authored and billyvg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    6a1362b View commit details
    Browse the repository at this point in the history

  3. better splitting of selectors (rrweb-io#1440) 

    * better splitting of selectors - overlapping with rrweb-io#1401 
* Add test from example at PostHog/posthog#21427
* ignore brackets inside selector strings
* Add another test as noticed that it's possible to escape strings
* Ensure we are ignoring commas within strings

Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
    @daibhin @eoghanmurray @billyvg
    2 people authored and billyvg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    020cfd9 View commit details
    Browse the repository at this point in the history

  4. sentry: add existing sentry tests

    @billyvg
    billyvg committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    4c76050 View commit details
    Browse the repository at this point in the history