fix: remote CSS does not get rebuilt properly #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where inlined CSS from a remotely loaded `<link>` does not get applied properly due to object reference mutation.
billyvg
commented
Dec 6, 2024
| ); | ||
| const newNode = buildNodeWithSN(newSn, { |
There was a problem hiding this comment.
If you look above at the Object.assign call, you'll see that we mutate the meta object reference from the mirror and pass it to buildNodeWithSN(). Looking inside of buildNodeWithSN() you can see that it ends up comparing the same object reference and returning the node from the mirror instead of building a new node.
if (mirror.has(n.id)) {
const nodeInMirror = mirror.getNode(n.id)!;
const meta = mirror.getMeta(nodeInMirror)!;
if (isNodeMetaEqual(meta, n)) return mirror.getNode(n.id);
}This meant that remote stylesheets were always loaded remotely (even if you inline) and could be blocked by CORS, making the inlined CSS rules unused.
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 12, 2024
Includes the following fixes: - fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226)) - fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227)) - fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where inlined CSS from a remotely loaded
<link>does not get applied properly due to object reference mutation.