Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading source of exception (raven.js) #227

Closed
sergunich opened this issue Jul 15, 2014 · 2 comments
Closed

Misleading source of exception (raven.js) #227

sergunich opened this issue Jul 15, 2014 · 2 comments

Comments

@sergunich
Copy link

With any applied plugin the source of top stack frame exception is code from raven.js:

  try {
    /*jshint -W040*/
    return func.apply(this, args);
  } catch(e) {
    Raven.captureException(e, options);
    throw e;  // <-- source of exception
  }

Example of stacktrace:

/static/libs/raven/raven.js  ? in ? at line 1270
/static/bookmarks.js  ? in Backbone.Model.extend.initialize at line 158:13
/static/libs/backbone-1.1.0.js  ? in Backbone.Model at line 256:21
/static/bookmarks.js  ? in ? at line 146:19
/  ? in requireDep at line 37:60
/  ? in initWidgets at line 53:42
/  ? in HTMLDocument.<anonymous> at line 402:9
/static/libs/raven/raven.js  ? in HTMLDocument.wrapped at line 1267:29
/static/libs/jquery-1.11.0.js  ? in fire at line 3099:30

Which is confusing because link to this file is used as title for error in stream dashboard:

http://192.168.1.83:9000/static/libs/raven/raven.js   //example of title

With IE8 situation is worse, because we receive only top stack frame. so for all exceptions we would have something like this stacktrace:

http://192.168.1.83:9000/static/libs/raven/raven.js

Which is useless.

I use raven.js ver. 1.1.15 from dist folder.
Is this bug or I just don't understand something?
Thanks!

@thomasbachem
Copy link

I guess this is a duplicate of #200.

@mattrobenolt
Copy link
Contributor

Yeah, this is the same as #200, closing in favor of a solution there.

billyvg added a commit that referenced this issue Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg added a commit that referenced this issue Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg added a commit that referenced this issue Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly
([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS
([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"]
([#228](getsentry/rrweb#228))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants