Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All links under point performance are broken #3145

Open
michaelmairegger opened this issue Jun 19, 2024 · 12 comments · May be fixed by #3152
Open

All links under point performance are broken #3145

michaelmairegger opened this issue Jun 19, 2024 · 12 comments · May be fixed by #3152

Comments

@michaelmairegger
Copy link

michaelmairegger commented Jun 19, 2024

Self-Hosted Version

24.6.0

CPU Architecture

x86_64

Docker Version

24.0.7

Docker Compose Version

2.27.1

Steps to Reproduce

Click on Queries and the new page shows:

The organization you were looking for was not found.

Expected Result

For e.g. queries the folowing URL should open:
https://.../organizations/sentry/insights/database/

Actual Result

For e.g. queries the following URL opens:

https://.../insights/database/

Event ID

No response

@cavanierc
Copy link

Hello,
I have the same issue after upgrade to 24.6.0

@SmoshySmosh
Copy link

I am currently experiencing the same after upgrading.

@aldy505
Copy link
Collaborator

aldy505 commented Jun 20, 2024

@KevinL10 @gggritso Hey, do you guys know anything related to this? I saw this PR that probably made the change, but since it's included in 24.5.1, I'm not too sure.

@pavel-boev
Copy link

Enabling of feature "organizations:performance-insights" fixed this for me, but I still have useless "Caches", "Queues" and "LLM Monitoring" in navigation

@aldy505
Copy link
Collaborator

aldy505 commented Jun 20, 2024

Enabling of feature "organizations:performance-insights" fixed this for me, but I still have useless "Caches", "Queues" and "LLM Monitoring" in navigation

@pavel-boev Would you like to add these features and then re-run install.sh script?

    # Rename current Performance modules to "Insights"
    "organizations:performance-insights",
    # Show links and upsells to Insights modules
    "organizations:insights-entry-points",
    # Enable access to initial Insights modules (Queries, Requests, Vitals, App Starts, Page Loads, Resources)
    "organizations:insights-initial-modules",
    # Enable access to newer Insights modules (Caches, Queues, LLMs, Mobile UI)
    "organizations:insights-addon-modules",

(from https://github.com/getsentry/sentry/blob/b0a45b072fb0cfceec3be5cad8e7a06ac58e60b1/src/sentry/features/temporary.py#L224-L225 and https://github.com/getsentry/sentry/blob/b0a45b072fb0cfceec3be5cad8e7a06ac58e60b1/src/sentry/features/temporary.py#L399-L404)

@pavel-boev
Copy link

I prefer to keep "organizations:insights-addon-modules" disabled, because we don't use sentry for backend. But I still see these modules in the navigation with the disabled feature.

@LordSimal
Copy link

LordSimal commented Jun 20, 2024

Adding the 3 feature flags mentioned above to the sentry/sentry.conf.py and doing a ./install.sh does not fix this issue.

Its just weird, that the main menu item for Performance is working ( aka the link /organizations/myorg/performance/) but any link underneath (like /organizations/myorg/performance/database/) redirects to /insights/database/

In fact if I manually enter the URL /organizations/myorg/insights/database/ it works just fine. So something is stripping the /organizations/myorg/ part of the URL

@zKoz210
Copy link
Contributor

zKoz210 commented Jun 20, 2024

@LordSimal work for me

    "organizations:performance-insights",
    # Show links and upsells to Insights modules
    "organizations:insights-entry-points",
    # Enable access to initial Insights modules (Queries, Requests, Vitals, App Starts, Page Loads, Resources)
    "organizations:insights-initial-modules",
    # Enable access to newer Insights modules (Caches, Queues, LLMs, Mobile UI)
    "organizations:insights-addon-modules",
image

@LordSimal
Copy link

LordSimal commented Jun 20, 2024

Indeed, I was missing organizations:performance-insights as well, so the following 2 features should be added to the sentry.config.py (as well as the sentry.config.example.py in this repo 😉)

"organizations:insights-addon-modules",
"organizations:performance-insights",

with that all the menu items work again

@gggritso
Copy link
Member

👋🏻 hi everyone, sorry about the linking confusion!

@aldy505 do you mind making that change and/or pointing me to where I should make it?

@stumbaumr
Copy link

This was the first issue I found regarding the error message: getsentry/sentry#53431
Linking it here to make this issue appear over there...

@aldy505
Copy link
Collaborator

aldy505 commented Jun 28, 2024

This was the first issue I found regarding the error message: getsentry/sentry#53431

Linking it here to make this issue appear over there...

@stumbaumr This issue is not related to session replay. Are you referring to other issue? Or can you specify more of what you're experiencing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

Successfully merging a pull request may close this issue.

9 participants