Fix permission denied error when extracting sentry-cli concurrently (#…

…748)
getsentry · Aug 5, 2024 · a3c33bf · a3c33bf
1 parent 4c54dc2
commit a3c33bf
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 - Fix plugin for spring-dependency-management 1.1.6 ([#741](https://github.com/getsentry/sentry-android-gradle-plugin/pull/741))
 - Make `SentryUploadNativeSymbolsTask` configuration-cache compatible ([#747](https://github.com/getsentry/sentry-android-gradle-plugin/pull/747))
+- Fix `permission denied` error when extracting sentry-cli concurrently ([#748](https://github.com/getsentry/sentry-android-gradle-plugin/pull/748))
 
 ### Dependencies
 

diff --git a/plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryCliProvider.kt b/plugin-build/src/main/kotlin/io/sentry/android/gradle/SentryCliProvider.kt
@@ -153,6 +153,7 @@ internal object SentryCliProvider {
     /**
      * Tries to extract the sentry-cli from resources if the computedCliPath does not exist.
      */
+    @Synchronized
     internal fun maybeExtractFromResources(buildDir: File, cliPath: String): String {
         val cli = File(cliPath)
         if (!cli.exists()) {

diff --git a/...rc/test/kotlin/io/sentry/android/gradle/integration/SentryPluginConfigurationCacheTest.kt b/...rc/test/kotlin/io/sentry/android/gradle/integration/SentryPluginConfigurationCacheTest.kt
@@ -224,11 +224,35 @@ class SentryPluginConfigurationCacheTest :
             `is`(true)
         )
 
+        appBuildFile.writeText(
+            // language=Groovy
+            """
+            plugins {
+              id "com.android.application"
+              id "io.sentry.android.gradle"
+            }
+
+            android {
+              namespace 'com.example'
+            }
+
+            sentry {
+              includeNativeSources = true
+              uploadNativeSymbols = true
+              includeProguardMapping = true
+              autoUploadProguardMapping = true
+              autoInstallation.enabled = false
+              telemetry = false
+            }
+            """.trimIndent()
+        )
+
         val runner = runner.withArguments(
             "--configuration-cache",
             "--build-cache",
             ":app:clean",
-            ":app:assembleRelease"
+            ":app:assembleRelease",
+            "--stacktrace"
         )
 
         val run = runner.build()