Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission denied error when extracting sentry-cli concurrently #748

Merged
merged 16 commits into from
Aug 5, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Aug 2, 2024

📜 Description

The test was not failing because we did not run any sentry tasks 🫠 After flipping some flags, it started to consistently fail for me, and the fix was simple - synchronize access to the sentry-cli extraction method.

💡 Motivation and Context

Fixes #728

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Base automatically changed from rz/fix/native-symbols-config-cache to main August 5, 2024 09:50
@romtsn romtsn merged commit a3c33bf into main Aug 5, 2024
18 checks passed
@romtsn romtsn deleted the rz/fix/missing-cli-on-clean branch August 5, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A problem occurred starting sentry-cli-2.31.2.exe on Linux
2 participants