Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission denied error when extracting sentry-cli concurrently #748

Merged
merged 16 commits into from
Aug 5, 2024
Merged
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Fix plugin for spring-dependency-management 1.1.6 ([#741](https://github.com/getsentry/sentry-android-gradle-plugin/pull/741))
- Make `SentryUploadNativeSymbolsTask` configuration-cache compatible ([#747](https://github.com/getsentry/sentry-android-gradle-plugin/pull/747))
- Fix `permission denied` error when extracting sentry-cli concurrently ([#748](https://github.com/getsentry/sentry-android-gradle-plugin/pull/748))

### Dependencies

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ internal object SentryCliProvider {
/**
* Tries to extract the sentry-cli from resources if the computedCliPath does not exist.
*/
@Synchronized
internal fun maybeExtractFromResources(buildDir: File, cliPath: String): String {
val cli = File(cliPath)
if (!cli.exists()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,35 @@ class SentryPluginConfigurationCacheTest :
`is`(true)
)

appBuildFile.writeText(
// language=Groovy
"""
plugins {
id "com.android.application"
id "io.sentry.android.gradle"
}

android {
namespace 'com.example'
}

sentry {
includeNativeSources = true
uploadNativeSymbols = true
includeProguardMapping = true
autoUploadProguardMapping = true
autoInstallation.enabled = false
telemetry = false
}
""".trimIndent()
)

val runner = runner.withArguments(
"--configuration-cache",
"--build-cache",
":app:clean",
":app:assembleRelease"
":app:assembleRelease",
"--stacktrace"
)

val run = runner.build()
Expand Down
Loading