This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
add auto session tracking flag #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
suggested changes
Apr 1, 2020
| @@ -58,6 +58,9 @@ | |||
| <!-- how to enable session tracking--> | |||
| <meta-data android:name="io.sentry.session-tracking.enable" android:value="true" /> | |||
|
|
|||
| <!-- how to enable auto session tracking integration--> | |||
There was a problem hiding this comment.
I'm not sure I follow what would be the use case for io.sentry.session-tracking.enable
There was a problem hiding this comment.
In other words: Doesn't the new field replace the old one?
|
in favor of #338 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
add auto session tracking flag
💡 Motivation and Context
we have a single flag to control 2 behavior.
1 is to enable session tracking at all.
2 is to enable the automatic session tracking integration.
it is a use case where one wants to start and end a session manually and to not do it automatically, this flag allows that.
💚 How did you test it?
unit test
📝 Checklist
🔮 Next steps