Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

removing session tracking guard on hub and client #338

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 2, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

removing session tracking guard on hub and client.

💡 Motivation and Context

one would like to start and end sessions manually, but still having the automatic session tracking disabled.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • [ ] I added tests to verify changes
  • All tests passing

🔮 Next steps

@marandaneto marandaneto mentioned this pull request Apr 2, 2020
7 tasks
@codecov-io
Copy link

Codecov Report

Merging #338 into master will decrease coverage by 0.13%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #338      +/-   ##
============================================
- Coverage     59.07%   58.94%   -0.14%     
+ Complexity      766      762       -4     
============================================
  Files            87       87              
  Lines          3548     3539       -9     
  Branches        344      341       -3     
============================================
- Hits           2096     2086      -10     
- Misses         1300     1302       +2     
+ Partials        152      151       -1
Impacted Files Coverage Δ Complexity Δ
...re/src/main/java/io/sentry/core/SentryOptions.java 75.31% <ø> (-1.9%) 69 <0> (-2)
sentry-core/src/main/java/io/sentry/core/Hub.java 65.26% <ø> (-0.82%) 60 <0> (-2)
...ore/src/main/java/io/sentry/core/SentryClient.java 90.85% <94.73%> (+1.15%) 51 <8> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 314952b...78d1d4e. Read the comment docs.

@marandaneto marandaneto merged commit 3ca016c into master Apr 2, 2020
@marandaneto marandaneto deleted the fix/remove-tracking-guard-hub-client branch April 2, 2020 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants