Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ios swift additions for profiling #3216

Merged
merged 10 commits into from
Aug 16, 2023

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Aug 10, 2023

Adds a new screen of options that have been helpful testing profiling features, and added benchmarking controls, obviating the old view controller that used to run it:
image

as well as launch arguments to selectively disable different SDK options:
image

#skip-changelog

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #3216 (8300e9b) into main (39a4941) will increase coverage by 0.014%.
The diff coverage is 88.679%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3216       +/-   ##
=============================================
+ Coverage   89.162%   89.177%   +0.014%     
=============================================
  Files          502       502               
  Lines        54073     54127       +54     
  Branches     19418     19425        +7     
=============================================
+ Hits         48213     48269       +56     
+ Misses        5000      4999        -1     
+ Partials       860       859        -1     
Files Changed Coverage Δ
Sources/Sentry/SentrySystemWrapper.mm 60.000% <57.142%> (-0.656%) ⬇️
Sources/Sentry/SentryMetricProfiler.mm 93.939% <100.000%> (+1.558%) ⬆️
...SentryProfilerTests/SentryProfilerSwiftTests.swift 97.551% <100.000%> (+0.033%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a4941...8300e9b. Read the comment docs.

@armcknight armcknight force-pushed the armcknight/test/ios-swift-additions branch from 3c809e3 to 966e52b Compare August 10, 2023 09:46
@armcknight armcknight changed the title Armcknight/test/ios swift additions test: ios swift additions for profiling Aug 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1246.29 ms 1261.94 ms 15.65 ms
Size 22.84 KiB 403.52 KiB 380.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
28333b6 1186.29 ms 1225.18 ms 38.89 ms
a9103fe 1221.49 ms 1243.33 ms 21.84 ms
98a8c16 1206.40 ms 1232.14 ms 25.74 ms
1db04d8 1250.20 ms 1258.12 ms 7.92 ms
60dd0f5 1212.24 ms 1240.82 ms 28.58 ms
443723a 1205.24 ms 1220.52 ms 15.28 ms
c021422 1199.15 ms 1222.20 ms 23.05 ms
1bbcb9c 1192.51 ms 1231.96 ms 39.45 ms
7cd187e 1239.39 ms 1258.02 ms 18.63 ms
c0b4b71 1218.16 ms 1251.28 ms 33.12 ms

App size

Revision Plain With Sentry Diff
28333b6 20.76 KiB 424.69 KiB 403.93 KiB
a9103fe 20.76 KiB 426.95 KiB 406.19 KiB
98a8c16 20.76 KiB 431.00 KiB 410.24 KiB
1db04d8 20.76 KiB 435.50 KiB 414.74 KiB
60dd0f5 20.76 KiB 393.37 KiB 372.61 KiB
443723a 20.76 KiB 414.44 KiB 393.68 KiB
c021422 20.76 KiB 435.64 KiB 414.88 KiB
1bbcb9c 20.76 KiB 426.10 KiB 405.34 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
c0b4b71 20.76 KiB 430.98 KiB 410.22 KiB

Previous results on branch: armcknight/test/ios-swift-additions

Startup times

Revision Plain With Sentry Diff
ebf73c1 1212.20 ms 1252.00 ms 39.80 ms
fbf1d89 1210.94 ms 1235.38 ms 24.44 ms
0e3927e 1247.45 ms 1255.83 ms 8.38 ms

App size

Revision Plain With Sentry Diff
ebf73c1 22.84 KiB 402.63 KiB 379.79 KiB
fbf1d89 22.84 KiB 403.14 KiB 380.29 KiB
0e3927e 22.84 KiB 403.52 KiB 380.67 KiB

@armcknight armcknight force-pushed the armcknight/test/ios-swift-additions branch from a5b8747 to da8cbee Compare August 11, 2023 21:25
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I have only one suggestion to talk about.

@armcknight
Copy link
Member Author

armcknight commented Aug 16, 2023

I forgot i stacked the energy usage PR to merge into this one. I needed to finish the mock tests for energy usage, which will go in with this PR.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armcknight armcknight merged commit efb0147 into main Aug 16, 2023
@armcknight armcknight deleted the armcknight/test/ios-swift-additions branch August 16, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants