-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: ios swift additions for profiling #3216
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
=============================================
+ Coverage 89.162% 89.177% +0.014%
=============================================
Files 502 502
Lines 54073 54127 +54
Branches 19418 19425 +7
=============================================
+ Hits 48213 48269 +56
+ Misses 5000 4999 -1
+ Partials 860 859 -1
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
3c809e3
to
966e52b
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
28333b6 | 1186.29 ms | 1225.18 ms | 38.89 ms |
a9103fe | 1221.49 ms | 1243.33 ms | 21.84 ms |
98a8c16 | 1206.40 ms | 1232.14 ms | 25.74 ms |
1db04d8 | 1250.20 ms | 1258.12 ms | 7.92 ms |
60dd0f5 | 1212.24 ms | 1240.82 ms | 28.58 ms |
443723a | 1205.24 ms | 1220.52 ms | 15.28 ms |
c021422 | 1199.15 ms | 1222.20 ms | 23.05 ms |
1bbcb9c | 1192.51 ms | 1231.96 ms | 39.45 ms |
7cd187e | 1239.39 ms | 1258.02 ms | 18.63 ms |
c0b4b71 | 1218.16 ms | 1251.28 ms | 33.12 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
28333b6 | 20.76 KiB | 424.69 KiB | 403.93 KiB |
a9103fe | 20.76 KiB | 426.95 KiB | 406.19 KiB |
98a8c16 | 20.76 KiB | 431.00 KiB | 410.24 KiB |
1db04d8 | 20.76 KiB | 435.50 KiB | 414.74 KiB |
60dd0f5 | 20.76 KiB | 393.37 KiB | 372.61 KiB |
443723a | 20.76 KiB | 414.44 KiB | 393.68 KiB |
c021422 | 20.76 KiB | 435.64 KiB | 414.88 KiB |
1bbcb9c | 20.76 KiB | 426.10 KiB | 405.34 KiB |
7cd187e | 20.76 KiB | 401.65 KiB | 380.89 KiB |
c0b4b71 | 20.76 KiB | 430.98 KiB | 410.22 KiB |
Previous results on branch: armcknight/test/ios-swift-additions
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ebf73c1 | 1212.20 ms | 1252.00 ms | 39.80 ms |
fbf1d89 | 1210.94 ms | 1235.38 ms | 24.44 ms |
0e3927e | 1247.45 ms | 1255.83 ms | 8.38 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ebf73c1 | 22.84 KiB | 402.63 KiB | 379.79 KiB |
fbf1d89 | 22.84 KiB | 403.14 KiB | 380.29 KiB |
0e3927e | 22.84 KiB | 403.52 KiB | 380.67 KiB |
a5b8747
to
da8cbee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I have only one suggestion to talk about.
Samples/iOS-Swift/iOS-Swift.xcodeproj/xcshareddata/xcschemes/iOS-Swift.xcscheme
Outdated
Show resolved
Hide resolved
I forgot i stacked the energy usage PR to merge into this one. I needed to finish the mock tests for energy usage, which will go in with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds a new screen of options that have been helpful testing profiling features, and added benchmarking controls, obviating the old view controller that used to run it:
![image](https://private-user-images.githubusercontent.com/3241469/260154073-eea56251-802d-4489-a668-9edb5a289913.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODUyNDEsIm5iZiI6MTczOTM4NDk0MSwicGF0aCI6Ii8zMjQxNDY5LzI2MDE1NDA3My1lZWE1NjI1MS04MDJkLTQ0ODktYTY2OC05ZWRiNWEyODk5MTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMTgyOTAxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OGY1YWI0YTU1NDdiMzViYjg5OTE0Y2MxNzkwZTU0MTcyOTc4MTA0ZjU4YWQzMDE5M2Y2MWE4YzM3YzhjMjlmOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ._40NgbwzVNYn-ZSu5pi5J7jtAwCy3P737aEd2bNu7W4)
as well as launch arguments to selectively disable different SDK options:
![image](https://private-user-images.githubusercontent.com/3241469/259699651-040f04a8-daac-46d7-b4fd-d0a252e168b7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODUyNDEsIm5iZiI6MTczOTM4NDk0MSwicGF0aCI6Ii8zMjQxNDY5LzI1OTY5OTY1MS0wNDBmMDRhOC1kYWFjLTQ2ZDctYjRmZC1kMGEyNTJlMTY4YjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTJUMTgyOTAxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjJiZGQzNTg1Y2Y1NTQ0YmYzNjU3NWIzMDU4MDQyNTM4MDU0YTY5MzFlMzNiOWRkNjVhOTAwMmZjN2UxMjIzYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Jmlp7maOibJLKb0r0qJVprZuQTGR3AJ7NlOZda83gco)
#skip-changelog