Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IBAction connections #3228

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix IBAction connections #3228

merged 1 commit into from
Aug 17, 2023

Conversation

armcknight
Copy link
Member

The IBAction connections for CPU work start/end in the new profiling area added in #3216 were not hooked up right and crashed the app.

#skip-changelog

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #3228 (abdcd5e) into main (efb0147) will increase coverage by 0.001%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3228       +/-   ##
=============================================
+ Coverage   89.149%   89.151%   +0.001%     
=============================================
  Files          501       502        +1     
  Lines        53824     54138      +314     
  Branches     19124     19435      +311     
=============================================
+ Hits         47984     48265      +281     
- Misses        4982      5013       +31     
- Partials       858       860        +2     

see 62 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb0147...abdcd5e. Read the comment docs.

@armcknight armcknight merged commit 9e6665f into main Aug 17, 2023
@armcknight armcknight deleted the armcknight/fix/ios-swift-crashes branch August 17, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants