Fix: Do not set the transaction to scope if no op (#828)

getsentry · Apr 12, 2022 · 9af7777 · 9af7777
1 parent 9cd2c20
commit 9af7777
Show file tree

Hide file tree

Showing 5 changed files with 149 additions and 76 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+* Fix: Do not set the transaction to scope if no op (#828)
+
 ## 6.5.0-beta.1
 
 - No documented changes.

diff --git a/flutter/lib/src/navigation/sentry_navigator_observer.dart b/flutter/lib/src/navigation/sentry_navigator_observer.dart
@@ -182,6 +182,12 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
       },
     );
 
+    // if _enableAutoTransactions is enabled but there's no traces sample rate
+    if (_transaction is NoOpSentrySpan) {
+      _transaction = null;
+      return;
+    }
+
     if (arguments != null) {
       _transaction?.setData('route_settings_arguments', arguments);
     }

diff --git a/flutter/test/mocks.dart b/flutter/test/mocks.dart
@@ -2,6 +2,7 @@ import 'package:flutter/services.dart';
 import 'package:mockito/annotations.dart';
 import 'package:sentry/sentry.dart';
 import 'package:sentry/src/platform/platform.dart';
+import 'package:sentry/src/sentry_tracer.dart';
 
 import 'package:meta/meta.dart';
 import 'package:sentry_flutter/src/sentry_native.dart';
@@ -25,12 +26,13 @@ ISentrySpan startTransactionShim(
   Function(ISentrySpan)? onFinish,
   Map<String, dynamic>? customSamplingContext,
 }) {
-  return MockNoOpSentrySpan();
+  return MockSentryTracer();
 }
 
 @GenerateMocks([
   Transport,
-  NoOpSentrySpan,
+  // ignore: invalid_use_of_internal_member
+  SentryTracer,
   MethodChannel,
   SentryNative,
 ], customMocks: [