Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not set the transaction to scope if no op #828

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 12, 2022

📜 Description

Fix: Do not set the transaction to scope if no op

💡 Motivation and Context

Closes #826

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto requested a review from brustolin as a code owner April 12, 2022 08:24
@marandaneto marandaneto requested a review from denrase April 12, 2022 08:25
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #828 (95ae670) into main (9cd2c20) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   89.83%   89.84%           
=======================================
  Files         114      114           
  Lines        3670     3672    +2     
=======================================
+ Hits         3297     3299    +2     
  Misses        373      373           
Impacted Files Coverage Δ
.../lib/src/navigation/sentry_navigator_observer.dart 98.75% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd2c20...95ae670. Read the comment docs.

@marandaneto marandaneto changed the title Fix: Do not find the transaction to scope if no op Fix: Do not set the transaction to scope if no op Apr 12, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 9af7777 into main Apr 12, 2022
@marandaneto marandaneto deleted the fix/no-op-transaction branch April 12, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any version > 6.2.2 ; "There were 2 problems processing this event"
3 participants