Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Added dramatiq integration getting started #11015

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Aug 7, 2024

DESCRIBE YOUR PR

Python SDK has a new integration for the Dramatiq background tasks library.

Preview: https://sentry-docs-git-antonpirker-pythondramatiq.sentry.dev/platforms/python/integrations/dramatiq/

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:39pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:39pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:39pm

Copy link

codecov bot commented Aug 7, 2024

Bundle Report

Changes will increase total bundle size by 189 bytes ⬆️

Bundle name Size Change
sentry-docs-server 8.25MB 198 bytes ⬆️
sentry-docs-client 6.24MB 6 bytes ⬇️
sentry-docs-edge-server 252.6kB 3 bytes ⬇️

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@antonpirker
Copy link
Member Author

@vivianyentran I added an Alert at the top to credit the original maintainer. Could you have a look if this is proper English?

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one tiny improvement suggestion

docs/platforms/python/integrations/dramatiq/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
@antonpirker antonpirker enabled auto-merge (squash) August 13, 2024 13:01
@antonpirker antonpirker merged commit 8b97b0b into master Aug 13, 2024
9 checks passed
@antonpirker antonpirker deleted the antonpirker/python/dramatiq branch August 13, 2024 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants