-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dramatiq integration from @jacobsvante #3397
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3397 +/- ##
=======================================
Coverage 79.78% 79.79%
=======================================
Files 133 134 +1
Lines 14418 14503 +85
Branches 3036 3052 +16
=======================================
+ Hits 11504 11573 +69
- Misses 2083 2091 +8
- Partials 831 839 +8
|
…thon into antonpirker/dramatiq
Tested with this example project: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See some small comments. Overall LGTM. Thanks for porting <3
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
Thank you so much for integrating it ❤️ |
This is the code from [sentry-dramatiq](https://github.com/jacobsvante/sentry-dramatiq). As described in this GitHub issue (#3387) @jacobsvante, the original maintainer of this integration, is not doing any Python anymore and wants to donate his integration to Sentry so we can take care of it. This PR adds the current version of the `DramatiqIntegration` to our repo. (The original integrations has been ported to the new SDK 2.x API) Fixes #3387 --------- Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
This is the code from [sentry-dramatiq](https://github.com/jacobsvante/sentry-dramatiq). As described in this GitHub issue (getsentry#3387) @jacobsvante, the original maintainer of this integration, is not doing any Python anymore and wants to donate his integration to Sentry so we can take care of it. This PR adds the current version of the `DramatiqIntegration` to our repo. (The original integrations has been ported to the new SDK 2.x API) Fixes getsentry#3387 --------- Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
This is the code of sentry-dramatiq.
As described in this GitHub issue (#3387) @jacobsvante, the original maintainer of this integations, is not doing any Python anymore and wants to donate his integration to Sentry so we can take care of it.
This PR adds the current version of the
DramatiqIntegration
to our repo.Fixes #3387
Documentation PR: getsentry/sentry-docs#11015